[Android] Update strings and improve playlist workflow

Yashraj Singh Jadon git at videolan.org
Tue Feb 13 10:36:01 UTC 2024


vlc-android | branch: master | Yashraj Singh Jadon <yashr7651 at gmail.com> | Thu Feb  1 04:04:37 2024 +0530| [5ebef33363d18f97b25e579c6990ba7d6d573d0a] | committer: Nicolas Pomepuy

Update strings and improve playlist workflow

> https://code.videolan.org/videolan/vlc-android/commit/5ebef33363d18f97b25e579c6990ba7d6d573d0a
---

 application/resources/src/main/res/values/strings.xml                  | 3 ++-
 application/vlc-android/res/layout/simple_item.xml                     | 3 +--
 .../src/org/videolan/vlc/gui/dialogs/DuplicationWarningDialog.kt       | 2 +-
 .../vlc-android/src/org/videolan/vlc/gui/dialogs/SavePlaylistDialog.kt | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/application/resources/src/main/res/values/strings.xml b/application/resources/src/main/res/values/strings.xml
index 53f3ab301d..c18721d345 100644
--- a/application/resources/src/main/res/values/strings.xml
+++ b/application/resources/src/main/res/values/strings.xml
@@ -809,7 +809,8 @@
     <string name="button_medialibrary_preferences">Go to Medialibrary preferences</string>
     <string name="light_theme">Light theme</string>
     <string name="add">Add</string>
-    <string name="add_to_new_playlist">Add to new or selected playlist</string>
+    <string name="add_to_new_playlist">Add to new playlist</string>
+    <string name="add_to_new_or_selected_playlist">Add to new or selected playlist</string>
     <string name="resume_card_message">Resume playback of %1$s?</string>
     <string name="misc">Miscellaneous</string>
     <string name="popup_force_legacy_title">Use custom Picture-in-Picture popup</string>
diff --git a/application/vlc-android/res/layout/simple_item.xml b/application/vlc-android/res/layout/simple_item.xml
index 54d1288acb..c94352b1b8 100644
--- a/application/vlc-android/res/layout/simple_item.xml
+++ b/application/vlc-android/res/layout/simple_item.xml
@@ -89,7 +89,7 @@
                 android:textColor="?attr/list_title"
                 android:textSize="16sp"
                 app:layout_constraintBottom_toTopOf="@+id/subtitle"
-            app:layout_constraintEnd_toStartOf="@+id/selected_check"
+                app:layout_constraintEnd_toStartOf="@+id/selected_check"
                 app:layout_constraintHorizontal_bias="0.5"
                 app:layout_constraintStart_toEndOf="@+id/imageView8"
                 app:layout_constraintTop_toTopOf="@+id/imageView8"
@@ -120,5 +120,4 @@
             app:srcCompat="@drawable/ic_video_grid_check"
             tools:visibility="visible" />
     </androidx.constraintlayout.widget.ConstraintLayout>
-
 </layout>
diff --git a/application/vlc-android/src/org/videolan/vlc/gui/dialogs/DuplicationWarningDialog.kt b/application/vlc-android/src/org/videolan/vlc/gui/dialogs/DuplicationWarningDialog.kt
index 5f26c42153..2b80d85b12 100644
--- a/application/vlc-android/src/org/videolan/vlc/gui/dialogs/DuplicationWarningDialog.kt
+++ b/application/vlc-android/src/org/videolan/vlc/gui/dialogs/DuplicationWarningDialog.kt
@@ -21,7 +21,7 @@ class DuplicationWarningDialog : VLCBottomSheetDialogFragment(), View.OnClickLis
 
     private var duplicatesCount: Int = 0
     private var highlightsCount: Int = 0
-    private var playlistTitle: String = "this"
+    private var playlistTitle: String = ""
 
     override fun initialFocusedView(): View {
         return if (shouldShowThreeOptions())
diff --git a/application/vlc-android/src/org/videolan/vlc/gui/dialogs/SavePlaylistDialog.kt b/application/vlc-android/src/org/videolan/vlc/gui/dialogs/SavePlaylistDialog.kt
index fa1b32dc63..a216916845 100644
--- a/application/vlc-android/src/org/videolan/vlc/gui/dialogs/SavePlaylistDialog.kt
+++ b/application/vlc-android/src/org/videolan/vlc/gui/dialogs/SavePlaylistDialog.kt
@@ -173,7 +173,7 @@ class SavePlaylistDialog : VLCBottomSheetDialogFragment(), View.OnClickListener,
                     processNextItem()
                 }
                 CANCEL, NO_OPTION -> {
-                    // do nothing
+                    processNextItem()
                 }
             }
         }



More information about the Android mailing list