- if (mTitle == null)<br>- return mFile.getName().substring(0, mFile.getName().lastIndexOf('.'));<br>- else<br>- return mTitle;<br>+ /* should never happen */<br>+ assert (mTitle != null);<br>
+ return mTitle;<br><br>i'm not sure it's true, vlc can answers with null metadata i think, especially for video files without metadata.<br><br>+ /**<br>+ * To maintain compatibility in a couple of places<br>
+ * Only used internally now<br>+ */<br>+ private File mFile_internal;<br><br>I'm not sur it is still needed.<br><br><br>+ } catch (URISyntaxException e) {<br>+ // URISyntax<br>
+ // Exception: Cannot happen<br>+ // But Java forced me<br>+ }<br>+<br><br>java forced you because of this :<br>+ public static URI VLCPathToURI(String path) throws URISyntaxException {<br>
<br>you can do the try/catch inside VLCPathToURI, then you won't need to add it at each use of VLCPathToURI.<br><br><br>The patch looks OK to me (didn't had time to test it yet) we can merge it and fix stuff after if necessary.<br>