<div class="gmail_quote">On Thu, Mar 29, 2012 at 6:07 PM, Edward Wang <span dir="ltr"><<a href="mailto:edward.c.wang@compdigitec.com">edward.c.wang@compdigitec.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 12-03-29 10:01 AM, Jean-Baptiste Kempf wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
- Network URL opening<br>
</blockquote>
I already posted a patch to do this, pending the imaginary toURI() penalty is resolved (I cannot reproduce this penalty, if you can, please post .trace file).<br></blockquote></div><br>yep, i did some tests :<br><br>- don't rename the Db column (in order to preserve exisiting databases)<br>
- remove useless mFile_internal<br>
- getTitle should fallback to filename if title==null (same as before)<br><br>(i fixed those locally)<br><br>
- in Media.cs, one constructor for URL is ok, but one constructor for
files which call the one for URL is weird. I think they should be
separated, with the common part is another method<br>
<br>
- java URI should not be used, it's too expensive on the cpu<br>
- there are also issues with URI stored in the DB, for instance delete doesn't work anymore with URI<br>
<br>I tried to remove URI completelly, but then i got issue with unicode because of libvlc_media_new_location.<br><br>
We could keep the path as it is for files, and just use
libvlc_media_new_location if location contains ":", else use
libvlc_media_new_path.<br>
libvlc_media_new_path encode the path to an URI and call libvlc_media_new_location, that's way faster than using java URI.<br><br>i'll send you a .trace file when i have the time.<br><br><br>