<div dir="ltr"><div><div>Good for me, and nice to have it :)<br><br></div>It's commited, but beware of indentation please.<br><br></div>Thanks for your contribution anymay !<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Apr 6, 2015 at 10:13 PM, Vladimír Pokorný <span dir="ltr"><<a href="mailto:vlada.pokorny@seznam.cz" target="_blank">vlada.pokorny@seznam.cz</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">---<br>
vlc-android/res/drawable/verticalbar_border.xml | 6 ++++<br>
vlc-android/res/layout/player.xml | 27 ++++++++++++++++++<br>
.../vlc/gui/video/VideoPlayerActivity.java | 32 ++++++++++++++++++++--<br>
3 files changed, 63 insertions(+), 2 deletions(-)<br>
create mode 100644 vlc-android/res/drawable/verticalbar_border.xml<br>
<br>
diff --git a/vlc-android/res/drawable/verticalbar_border.xml b/vlc-android/res/drawable/verticalbar_border.xml<br>
new file mode 100644<br>
index 0000000..276679e<br>
--- /dev/null<br>
+++ b/vlc-android/res/drawable/verticalbar_border.xml<br>
@@ -0,0 +1,6 @@<br>
+<?xml version="1.0" encoding="utf-8"?><br>
+<shape xmlns:android="<a href="http://schemas.android.com/apk/res/android" target="_blank">http://schemas.android.com/apk/res/android</a>" android:shape="rectangle"><br>
+ <solid android:color="#00000000" /><br>
+ <stroke android:width="1dp"<br>
+ android:color="#77ffffff" /><br>
+</shape><br>
\ No newline at end of file<br>
diff --git a/vlc-android/res/layout/player.xml b/vlc-android/res/layout/player.xml<br>
index a4906a6..6dfdc15 100644<br>
--- a/vlc-android/res/layout/player.xml<br>
+++ b/vlc-android/res/layout/player.xml<br>
@@ -77,6 +77,33 @@<br>
android:textColor="#ffffff"<br>
android:textSize="36sp"<br>
android:visibility="invisible" /><br>
+<br>
+ <FrameLayout android:id="@+id/verticalbar"<br>
+ android:layout_width="28dp"<br>
+ android:layout_height="100dp"<br>
+ android:layout_above="@+id/progress_overlay"<br>
+ android:layout_toLeftOf="@+id/player_overlay_info"<br>
+ android:layout_marginRight="8dp"<br>
+ android:layout_marginBottom="-16dp"<br>
+ android:background="@drawable/video_list_length_bg"<br>
+ android:visibility="invisible"><br>
+<br>
+ <LinearLayout android:layout_width="match_parent"<br>
+ android:layout_height="match_parent"<br>
+ android:layout_margin="7dp"<br>
+ android:background="@drawable/verticalbar_border"<br>
+ android:orientation="vertical"<br>
+ android:weightSum="15"<br>
+ android:gravity="bottom"><br>
+<br>
+ <View android:id="@+id/verticalbar_progress"<br>
+ android:layout_width="match_parent"<br>
+ android:layout_height="0dp"<br>
+ android:layout_margin="2dp"<br>
+ android:background="@color/orange500transparent" /><br>
+ </LinearLayout><br>
+ </FrameLayout><br>
+<br>
<ImageView<br>
android:id="@+id/player_delay_minus"<br>
android:layout_width="wrap_content"<br>
diff --git a/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java b/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java<br>
index a0ddf2c..06b43aa 100644<br>
--- a/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java<br>
+++ b/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java<br>
@@ -86,6 +86,7 @@ import android.view.animation.DecelerateInterpolator;<br>
import android.view.animation.RotateAnimation;<br>
import android.widget.FrameLayout;<br>
import android.widget.ImageView;<br>
+import android.widget.LinearLayout;<br>
import android.widget.RelativeLayout;<br>
import android.widget.SeekBar;<br>
import android.widget.SeekBar.OnSeekBarChangeListener;<br>
@@ -196,6 +197,8 @@ public class VideoPlayerActivity extends ActionBarActivity implements IVideoPlay<br>
private TextView mTime;<br>
private TextView mLength;<br>
private TextView mInfo;<br>
+ private View mVerticalBar;<br>
+ private View mVerticalBarProgress;<br>
private ImageView mLoading;<br>
private TextView mLoadingText;<br>
private ImageView mTipsBackground;<br>
@@ -397,6 +400,8 @@ public class VideoPlayerActivity extends ActionBarActivity implements IVideoPlay<br>
<br>
// the info textView is not on the overlay<br>
mInfo = (TextView) findViewById(R.id.player_overlay_info);<br>
+ mVerticalBar = findViewById(R.id.verticalbar);<br>
+ mVerticalBarProgress = findViewById(R.id.verticalbar_progress);<br>
<br>
mEnableBrightnessGesture = mSettings.getBoolean("enable_brightness_gesture", true);<br>
mScreenOrientation = Integer.valueOf(<br>
@@ -1194,11 +1199,26 @@ public class VideoPlayerActivity extends ActionBarActivity implements IVideoPlay<br>
}<br>
<br>
/**<br>
+ * Show text in the info view and vertical progress bar for "duration" milliseconds<br>
+ * @param text<br>
+ * @param duration<br>
+ * @param barNewValue new volume/brightness value (range: 0 - 15)<br>
+ */<br>
+ private void showInfoWithVerticalBar(String text, int duration, int barNewValue) {<br>
+ showInfo(text, duration);<br>
+ LinearLayout.LayoutParams layoutParams = (LinearLayout.LayoutParams) mVerticalBarProgress.getLayoutParams();<br>
+ layoutParams.weight = barNewValue;<br>
+ mVerticalBarProgress.setLayoutParams(layoutParams);<br>
+ mVerticalBar.setVisibility(View.VISIBLE);<br>
+ }<br>
+<br>
+ /**<br>
* Show text in the info view for "duration" milliseconds<br>
* @param text<br>
* @param duration<br>
*/<br>
private void showInfo(String text, int duration) {<br>
+ mVerticalBar.setVisibility(View.INVISIBLE);<br>
mInfo.setVisibility(View.VISIBLE);<br>
mInfo.setText(text);<br>
mHandler.removeMessages(FADE_OUT_INFO);<br>
@@ -1206,6 +1226,7 @@ public class VideoPlayerActivity extends ActionBarActivity implements IVideoPlay<br>
}<br>
<br>
private void showInfo(int textid, int duration) {<br>
+ mVerticalBar.setVisibility(View.INVISIBLE);<br>
mInfo.setVisibility(View.VISIBLE);<br>
mInfo.setText(textid);<br>
mHandler.removeMessages(FADE_OUT_INFO);<br>
@@ -1217,6 +1238,7 @@ public class VideoPlayerActivity extends ActionBarActivity implements IVideoPlay<br>
* @param text<br>
*/<br>
private void showInfo(String text) {<br>
+ mVerticalBar.setVisibility(View.INVISIBLE);<br>
mHandler.removeMessages(FADE_OUT_INFO);<br>
mInfo.setVisibility(View.VISIBLE);<br>
mInfo.setText(text);<br>
@@ -1243,6 +1265,11 @@ public class VideoPlayerActivity extends ActionBarActivity implements IVideoPlay<br>
mInfo.startAnimation(AnimationUtils.loadAnimation(<br>
VideoPlayerActivity.this, android.R.anim.fade_out));<br>
mInfo.setVisibility(View.INVISIBLE);<br>
+<br>
+ if (mVerticalBar.getVisibility() == View.VISIBLE)<br>
+ mVerticalBar.startAnimation(AnimationUtils.loadAnimation(<br>
+ VideoPlayerActivity.this, android.R.anim.fade_out));<br>
+ mVerticalBar.setVisibility(View.INVISIBLE);<br>
}<br>
<br>
private OnAudioFocusChangeListener mAudioFocusListener = !LibVlcUtil.isFroyoOrLater() ? null :<br>
@@ -1835,7 +1862,7 @@ public class VideoPlayerActivity extends ActionBarActivity implements IVideoPlay<br>
mAudioManager.setStreamVolume(AudioManager.STREAM_MUSIC, vol, AudioManager.FLAG_SHOW_UI);<br>
<br>
mTouchAction = TOUCH_VOLUME;<br>
- showInfo(getString(R.string.volume) + '\u00A0' + Integer.toString(vol),1000);<br>
+ showInfoWithVerticalBar(getString(R.string.volume) + '\u00A0' + Integer.toString(vol), 1000, vol);<br>
}<br>
<br>
private void mute(boolean mute) {<br>
@@ -1893,7 +1920,8 @@ public class VideoPlayerActivity extends ActionBarActivity implements IVideoPlay<br>
lp.screenBrightness = Math.min(Math.max(lp.screenBrightness + delta, 0.01f), 1);<br>
// Set Brightness<br>
getWindow().setAttributes(lp);<br>
- showInfo(getString(R.string.brightness) + '\u00A0' + Math.round(lp.screenBrightness * 15),1000);<br>
+ int brightness = Math.round(lp.screenBrightness * 15);<br>
+ showInfoWithVerticalBar(getString(R.string.brightness) + '\u00A0' + brightness, 1000, brightness);<br>
}<br>
<br>
/**<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.9.1<br>
<br>
_______________________________________________<br>
Android mailing list<br>
<a href="mailto:Android@videolan.org">Android@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/android" target="_blank">https://mailman.videolan.org/listinfo/android</a><br>
</font></span></blockquote></div><br></div>