<div dir="ltr">LGTM, thx for the contribution :)</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Nov 3, 2016 at 10:56 PM Evan Leis <<a href="mailto:evan.explodes@gmail.com">evan.explodes@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">VideoPlayerActivity was checking the wrong view's visibility<br class="gmail_msg">
to determine whether or not to apply the subtitle surface to<br class="gmail_msg">
the current IVLCVout. This could have led to an NPE.<br class="gmail_msg">
<br class="gmail_msg">
This not being an NPE is possibly evidence that mPresentation<br class="gmail_msg">
is not fully utilized and could possible be removed altogether.<br class="gmail_msg">
---<br class="gmail_msg">
 vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java | 2 +-<br class="gmail_msg">
 1 file changed, 1 insertion(+), 1 deletion(-)<br class="gmail_msg">
<br class="gmail_msg">
diff --git a/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java b/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java<br class="gmail_msg">
index 21f42a1..3b83322 100644<br class="gmail_msg">
--- a/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java<br class="gmail_msg">
+++ b/vlc-android/src/org/videolan/vlc/gui/video/VideoPlayerActivity.java<br class="gmail_msg">
@@ -784,7 +784,7 @@ public class VideoPlayerActivity extends AppCompatActivity implements IVLCVout.C<br class="gmail_msg">
                 vlcVout.setSubtitlesView(mSubtitlesSurfaceView);<br class="gmail_msg">
         } else {<br class="gmail_msg">
             vlcVout.setVideoView(mPresentation.mSurfaceView);<br class="gmail_msg">
-            if (mSubtitlesSurfaceView.getVisibility() != View.GONE)<br class="gmail_msg">
+            if (mPresentation.mSubtitlesSurfaceView.getVisibility() != View.GONE)<br class="gmail_msg">
                 vlcVout.setSubtitlesView(mPresentation.mSubtitlesSurfaceView);<br class="gmail_msg">
         }<br class="gmail_msg">
         vlcVout.addCallback(this);<br class="gmail_msg">
--<br class="gmail_msg">
2.7.4<br class="gmail_msg">
<br class="gmail_msg">
_______________________________________________<br class="gmail_msg">
Android mailing list<br class="gmail_msg">
<a href="mailto:Android@videolan.org" class="gmail_msg" target="_blank">Android@videolan.org</a><br class="gmail_msg">
<a href="https://mailman.videolan.org/listinfo/android" rel="noreferrer" class="gmail_msg" target="_blank">https://mailman.videolan.org/listinfo/android</a><br class="gmail_msg">
</blockquote></div>