<div dir="ltr"><i>getExternalStorageDirectories</i> returns external discovered storages.<br><div><i>getCustomDirectories</i> returns user custom directories<br></div><div><br></div><div>thus, MediaLibrary handles if storage has already been added.</div><div><br></div><div>I have to revert your patch.</div></div><br><div class="gmail_quote"><div dir="ltr">Le lun. 13 mars 2017 à 07:33, XilasZ <<a href="mailto:xilasz@gmail.com">xilasz@gmail.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto" class="gmail_msg">This list is a user setting, the list of folders to scan, using it to store external storage already discovered caused a regression : it is added/scan at each startup, even if the storage is not a new one.<div dir="auto" class="gmail_msg"><br class="gmail_msg"><div dir="auto" class="gmail_msg">A specific list, different from user settings is required i think.</div></div></div><div class="gmail_extra gmail_msg"><br class="gmail_msg"><div class="gmail_quote gmail_msg">Le 12 mars 2017 22:11, "Geoffrey Métais" <<a href="mailto:geoffrey.metais@gmail.com" class="gmail_msg" target="_blank">geoffrey.metais@gmail.com</a>> a écrit :<br type="attribution" class="gmail_msg"><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p dir="ltr" class="gmail_msg">That's not a reason for a major regression.<br class="gmail_msg">
And if storage is removed, it won't appear in discovered storage list. I don't see the big</p>
<br class="gmail_msg"><div class="gmail_quote gmail_msg"><div dir="ltr" class="gmail_msg">Le dim. 12 mars 2017 à 20:00, XilasZ <<a href="mailto:xilasz@gmail.com" class="gmail_msg" target="_blank">xilasz@gmail.com</a>> a écrit :<br class="gmail_msg"></div><blockquote class="gmail_quote gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto" class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">The issue was that vlc always discover external storage, even if the user removed it from folders to scan.</div><div class="gmail_extra m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg"><br class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg"><div class="gmail_quote m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">Le 12 mars 2017 13:04, "Geoffrey Métais" <<a href="mailto:geoffrey@videolan.org" class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg" target="_blank">geoffrey@videolan.org</a>> a écrit :<br type="attribution" class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg"><blockquote class="gmail_quote m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">In this case, VLC is not able to discover any new external storage.<div class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">I don't see the point of banning sdcards and USB keys.<br class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg"><br class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg"><div class="gmail_quote m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg"><div dir="ltr" class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">Le dim. 12 mars 2017 à 08:04, Sébastien Toque <<a href="mailto:git@videolan.org" class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg" target="_blank">git@videolan.org</a>> a écrit :<br class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg"></div><blockquote class="gmail_quote m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">vlc-android | branch: master | Sébastien Toque <<a href="mailto:xilasz@gmail.com" class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg" target="_blank">xilasz@gmail.com</a>> | Sun Mar 12 08:02:19 2017 +0100| [b231b09e7ad99455d6e970b5f675a4fb1697827f] | committer: Sébastien Toque<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
If folders are already specified, don't add external storage<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
> <a href="https://code.videolan.org/videolan/vlc-android/commit/b231b09e7ad99455d6e970b5f675a4fb1697827f" rel="noreferrer" class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg" target="_blank">https://code.videolan.org/videolan/vlc-android/commit/b231b09e7ad99455d6e970b5f675a4fb1697827f</a><br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
---<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
vlc-android/src/org/videolan/vlc/MediaParsingService.java | 3 ++-<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
1 file changed, 2 insertions(+), 1 deletion(-)<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
diff --git a/vlc-android/src/org/videolan/vlc/MediaParsingService.java b/vlc-android/src/org/videolan/vlc/MediaParsingService.java<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
index 2ce2575..4fdcc47 100644<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
--- a/vlc-android/src/org/videolan/vlc/MediaParsingService.java<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
+++ b/vlc-android/src/org/videolan/vlc/MediaParsingService.java<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
@@ -132,7 +132,8 @@ public class MediaParsingService extends Service implements DevicesDiscoveryCb {<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
mMedialibrary.forceParserRetry();<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
}<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
for (String externalStorage : AndroidDevices.getExternalStorageDirectories()) {<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
- if (!TextUtils.equals(externalStorage, AndroidDevices.EXTERNAL_PUBLIC_DIRECTORY)<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
+ if (foldersList.length == 0<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
+ && !TextUtils.equals(externalStorage, AndroidDevices.EXTERNAL_PUBLIC_DIRECTORY)<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
&& !Util.arrayContains(foldersList, "file://" + externalStorage + "/")) {<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
for (String folder : Medialibrary.getBlackList())<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
mMedialibrary.banFolder(externalStorage + folder);<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
_______________________________________________<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
Android mailing list<br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
<a href="mailto:Android@videolan.org" class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg" target="_blank">Android@videolan.org</a><br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
<a href="https://mailman.videolan.org/listinfo/android" rel="noreferrer" class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg" target="_blank">https://mailman.videolan.org/listinfo/android</a><br class="m_-5943581192920172242m_1926456590051693170m_-5458594459697745144m_3485685366521095817gmail_msg m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
</blockquote></div></div></div>
<br class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">_______________________________________________<br class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
Android mailing list<br class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
<a href="mailto:Android@videolan.org" class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg" target="_blank">Android@videolan.org</a><br class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
<a href="https://mailman.videolan.org/listinfo/android" rel="noreferrer" class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg" target="_blank">https://mailman.videolan.org/listinfo/android</a><br class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
<br class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg"></blockquote></div></div>
_______________________________________________<br class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
Android mailing list<br class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
<a href="mailto:Android@videolan.org" class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg" target="_blank">Android@videolan.org</a><br class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
<a href="https://mailman.videolan.org/listinfo/android" rel="noreferrer" class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg" target="_blank">https://mailman.videolan.org/listinfo/android</a><br class="m_-5943581192920172242m_1926456590051693170gmail_msg gmail_msg">
</blockquote></div>
<br class="gmail_msg">_______________________________________________<br class="gmail_msg">
Android mailing list<br class="gmail_msg">
<a href="mailto:Android@videolan.org" class="gmail_msg" target="_blank">Android@videolan.org</a><br class="gmail_msg">
<a href="https://mailman.videolan.org/listinfo/android" rel="noreferrer" class="gmail_msg" target="_blank">https://mailman.videolan.org/listinfo/android</a><br class="gmail_msg">
<br class="gmail_msg"></blockquote></div></div>
_______________________________________________<br class="gmail_msg">
Android mailing list<br class="gmail_msg">
<a href="mailto:Android@videolan.org" class="gmail_msg" target="_blank">Android@videolan.org</a><br class="gmail_msg">
<a href="https://mailman.videolan.org/listinfo/android" rel="noreferrer" class="gmail_msg" target="_blank">https://mailman.videolan.org/listinfo/android</a><br class="gmail_msg">
</blockquote></div>