<div dir="ltr">The general idea was to offload onCreate(…) in order to have the activities/fragments loaded faster.<br>I did not suspect onSaveInstanceState() could be called before onActivityCreated(…)…<br><br><div class="gmail_quote"><div dir="ltr">Le lun. 13 nov. 2017 à 21:00, Romain Vimont <<a href="mailto:rom@rom1v.com">rom@rom1v.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
Le lundi 13 novembre 2017 à 18:45 +0100, Geoffrey Métais a écrit :<br>
> vlc-android | branch: 2.5.x | Geoffrey Métais <<a href="mailto:geoffrey.metais@gmail.com" target="_blank">geoffrey.metais@gmail.com</a>> | Mon Nov 13 18:40:44 2017 +0100| [758c200e10ddac5cbad406d4107b431efcdaa2e6] | committer: Geoffrey Métais<br>
><br>
> Prevent NPE in browsers on device rotation<br>
><br>
> (cherry picked from commit 45c45adbd5b2b8972fdc28a450333285fa878190)<br>
><br>
> > <a href="https://code.videolan.org/videolan/vlc-android/commit/758c200e10ddac5cbad406d4107b431efcdaa2e6" rel="noreferrer" target="_blank">https://code.videolan.org/videolan/vlc-android/commit/758c200e10ddac5cbad406d4107b431efcdaa2e6</a><br>
> ---<br>
><br>
>  vlc-android/src/org/videolan/vlc/gui/browser/BaseBrowserFragment.java | 3 ++-<br>
>  1 file changed, 2 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/vlc-android/src/org/videolan/vlc/gui/browser/BaseBrowserFragment.java b/vlc-android/src/org/videolan/vlc/gui/browser/BaseBrowserFragment.java<br>
> index 2a1695b12..5aee19028 100644<br>
> --- a/vlc-android/src/org/videolan/vlc/gui/browser/BaseBrowserFragment.java<br>
> +++ b/vlc-android/src/org/videolan/vlc/gui/browser/BaseBrowserFragment.java<br>
> @@ -245,7 +245,8 @@ public abstract class BaseBrowserFragment extends SortableFragment<BaseBrowserAd<br>
>      public void onSaveInstanceState(Bundle outState){<br>
>          outState.putString(KEY_MRL, mMrl);<br>
>          outState.putParcelable(KEY_MEDIA, mCurrentMedia);<br>
> -        VLCApplication.storeData(KEY_MEDIA_LIST+mMrl, mAdapter.getAll());<br>
> +        if (mAdapter != null)<br>
<br>
Why not just initializing mAdapter in onCreate(…)?<br>
<br>
> +            VLCApplication.storeData(KEY_MEDIA_LIST+mMrl, mAdapter.getAll());<br>
>          VLCApplication.storeData(KEY_CONTENT_LIST+mMrl, mFoldersContentLists);<br>
>          if (mRecyclerView != null)<br>
>              outState.putInt(KEY_POSITION, mLayoutManager.findFirstCompletelyVisibleItemPosition());<br>
><br>
> _______________________________________________<br>
> Android mailing list<br>
> <a href="mailto:Android@videolan.org" target="_blank">Android@videolan.org</a><br>
> <a href="https://mailman.videolan.org/listinfo/android" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/android</a><br>
_______________________________________________<br>
Android mailing list<br>
<a href="mailto:Android@videolan.org" target="_blank">Android@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/android" rel="noreferrer" target="_blank">https://mailman.videolan.org/listinfo/android</a><br>
</blockquote></div></div>