<div dir="auto">Hi Team, <div dir="auto"><br></div><div dir="auto">I have applied to Google Season of Docs 2020 as a Technical Writer. I wish to work on VLC Android documentation.</div><div dir="auto"> <span style="font-family:sans-serif">Please guide me in approaching this issue. </span><br>Thank you.</div><div dir="auto">Merlyn.<br><div data-smartmail="gmail_signature" dir="auto"><a href="http://www.amazon.com/author/merlynshelley">www.amazon.com/author/merlynshelley</a></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Jun 2, 2020, 17:32 Nicolas Pomepuy <<a href="mailto:git@videolan.org">git@videolan.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">vlc-android | branch: master | Nicolas Pomepuy <<a href="mailto:nicolas@videolabs.io" target="_blank" rel="noreferrer">nicolas@videolabs.io</a>> | Tue Jun 2 10:16:28 2020 +0200| [c5db0c8ff58983d14f50eaab663779a32aed1b75] | committer: Nicolas Pomepuy<br>
<br>
Fix media number sort visibility<br>
<br>
Fixes #1371<br>
<br>
> <a href="https://code.videolan.org/videolan/vlc-android/commit/c5db0c8ff58983d14f50eaab663779a32aed1b75" rel="noreferrer noreferrer" target="_blank">https://code.videolan.org/videolan/vlc-android/commit/c5db0c8ff58983d14f50eaab663779a32aed1b75</a><br>
---<br>
<br>
.../java/org/videolan/television/ui/browser/BaseBrowserTvFragment.kt | 1 +<br>
application/vlc-android/src/org/videolan/vlc/gui/PlaylistActivity.kt | 1 +<br>
.../src/org/videolan/vlc/gui/audio/AudioAlbumsSongsFragment.kt | 1 +<br>
.../vlc-android/src/org/videolan/vlc/gui/audio/AudioBrowserFragment.kt | 1 +<br>
.../vlc-android/src/org/videolan/vlc/gui/browser/BaseBrowserFragment.kt | 1 +<br>
5 files changed, 5 insertions(+)<br>
<br>
diff --git a/application/television/src/main/java/org/videolan/television/ui/browser/BaseBrowserTvFragment.kt b/application/television/src/main/java/org/videolan/television/ui/browser/BaseBrowserTvFragment.kt<br>
index 753b8e874..dd1fee457 100644<br>
--- a/application/television/src/main/java/org/videolan/television/ui/browser/BaseBrowserTvFragment.kt<br>
+++ b/application/television/src/main/java/org/videolan/television/ui/browser/BaseBrowserTvFragment.kt<br>
@@ -314,6 +314,7 @@ abstract class BaseBrowserTvFragment<T> : Fragment(), BrowserFragmentInterface,<br>
menu.menu.findItem(R.id.ml_menu_sortby_date).isVisible = (viewModel as SortableModel).canSortByInsertionDate() || (viewModel as SortableModel).canSortByReleaseDate() || (viewModel as SortableModel).canSortByLastModified()<br>
menu.menu.findItem(R.id.ml_menu_sortby_date).isVisible = (viewModel as SortableModel).canSortByReleaseDate()<br>
menu.menu.findItem(R.id.ml_menu_sortby_last_modified).isVisible = (viewModel as SortableModel).canSortByLastModified()<br>
+ menu.menu.findItem(org.videolan.vlc.R.id.ml_menu_sortby_media_number).isVisible = false<br>
menu.menu.findItem(R.id.ml_menu_sortby_number).isVisible = false<br>
menu.setOnMenuItemClickListener(this)<br>
menu.show()<br>
diff --git a/application/vlc-android/src/org/videolan/vlc/gui/PlaylistActivity.kt b/application/vlc-android/src/org/videolan/vlc/gui/PlaylistActivity.kt<br>
index 55770fad0..e9610e207 100644<br>
--- a/application/vlc-android/src/org/videolan/vlc/gui/PlaylistActivity.kt<br>
+++ b/application/vlc-android/src/org/videolan/vlc/gui/PlaylistActivity.kt<br>
@@ -183,6 +183,7 @@ open class PlaylistActivity : AudioPlayerContainerActivity(), IEventsHandler<Med<br>
menu.findItem(R.id.ml_menu_sortby_length).isVisible = viewModel.canSortByDuration()<br>
menu.findItem(R.id.ml_menu_sortby_date).isVisible = viewModel.canSortByReleaseDate()<br>
menu.findItem(R.id.ml_menu_sortby_last_modified).isVisible = viewModel.canSortByLastModified()<br>
+ menu.findItem(R.id.ml_menu_sortby_media_number).isVisible = false<br>
return true<br>
}<br>
<br>
diff --git a/application/vlc-android/src/org/videolan/vlc/gui/audio/AudioAlbumsSongsFragment.kt b/application/vlc-android/src/org/videolan/vlc/gui/audio/AudioAlbumsSongsFragment.kt<br>
index 81519013a..1fca32141 100644<br>
--- a/application/vlc-android/src/org/videolan/vlc/gui/audio/AudioAlbumsSongsFragment.kt<br>
+++ b/application/vlc-android/src/org/videolan/vlc/gui/audio/AudioAlbumsSongsFragment.kt<br>
@@ -183,6 +183,7 @@ class AudioAlbumsSongsFragment : BaseAudioBrowser<AlbumSongsViewModel>(), SwipeR<br>
menu.findItem(R.id.ml_menu_sortby_number).isVisible = false<br>
menu.findItem(R.id.ml_menu_display_grid).isVisible = !viewModel.providersInCard[currentTab]<br>
menu.findItem(R.id.ml_menu_display_list).isVisible = viewModel.providersInCard[currentTab]<br>
+ menu.findItem(R.id.ml_menu_sortby_media_number).isVisible = canSortByMediaNumber()<br>
}<br>
sortMenuTitles()<br>
}<br>
diff --git a/application/vlc-android/src/org/videolan/vlc/gui/audio/AudioBrowserFragment.kt b/application/vlc-android/src/org/videolan/vlc/gui/audio/AudioBrowserFragment.kt<br>
index 31dd0b3aa..4e96ead3a 100644<br>
--- a/application/vlc-android/src/org/videolan/vlc/gui/audio/AudioBrowserFragment.kt<br>
+++ b/application/vlc-android/src/org/videolan/vlc/gui/audio/AudioBrowserFragment.kt<br>
@@ -235,6 +235,7 @@ class AudioBrowserFragment : BaseAudioBrowser<AudioBrowserViewModel>() {<br>
menu.findItem(R.id.ml_menu_sortby_number).isVisible = false<br>
menu.findItem(R.id.ml_menu_display_grid).isVisible = currentTab in 0..2 && !viewModel.providersInCard[currentTab]<br>
menu.findItem(R.id.ml_menu_display_list).isVisible = currentTab in 0..2 && viewModel.providersInCard[currentTab]<br>
+ menu.findItem(R.id.ml_menu_sortby_media_number).isVisible = canSortByMediaNumber()<br>
val showAllArtistsItem = menu.findItem(R.id.artists_show_all_title)<br>
showAllArtistsItem.isVisible = currentTab == 0<br>
showAllArtistsItem.isChecked = Settings.getInstance(context).getBoolean(KEY_ARTISTS_SHOW_ALL, false)<br>
diff --git a/application/vlc-android/src/org/videolan/vlc/gui/browser/BaseBrowserFragment.kt b/application/vlc-android/src/org/videolan/vlc/gui/browser/BaseBrowserFragment.kt<br>
index 34acaa048..341a6d639 100644<br>
--- a/application/vlc-android/src/org/videolan/vlc/gui/browser/BaseBrowserFragment.kt<br>
+++ b/application/vlc-android/src/org/videolan/vlc/gui/browser/BaseBrowserFragment.kt<br>
@@ -124,6 +124,7 @@ abstract class BaseBrowserFragment : MediaBrowserFragment<BrowserModel>(), IRefr<br>
super.onPrepareOptionsMenu(menu)<br>
menu.findItem(R.id.ml_menu_filter)?.isVisible = enableSearchOption()<br>
menu.findItem(R.id.ml_menu_sortby)?.isVisible = !isRootDirectory<br>
+ menu.findItem(R.id.ml_menu_sortby_media_number)?.isVisible = false<br>
menu.findItem(R.id.ml_menu_add_playlist)?.isVisible = !isRootDirectory<br>
addPlaylistFolderOnly = menu.findItem(R.id.folder_add_playlist)<br>
addPlaylistFolderOnly.isVisible = adapter.mediaCount > 0<br>
<br>
_______________________________________________<br>
Android mailing list<br>
<a href="mailto:Android@videolan.org" target="_blank" rel="noreferrer">Android@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/android" rel="noreferrer noreferrer" target="_blank">https://mailman.videolan.org/listinfo/android</a><br>
</blockquote></div>