<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div apple-content-edited="true">
</div>
<br><div><div>On Oct 2, 2013, at 1:30 PM, Jean-Paul Saman <<a href="mailto:jpsaman@videolan.org">jpsaman@videolan.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div class="gmail_extra">Brad,<br><br></div><div class="gmail_extra"><div class="gmail_quote">On Wed, Oct 2, 2013 at 7:03 PM, Brad Bitterman <span dir="ltr"><<a href="mailto:bitter@vtilt.com" target="_blank">bitter@vtilt.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">The patch works.<div><br></div><div>On another note, in atsc_mgt.c I think there might be an issue in dvbpsi_AddSectionMGT. At line 387 there is a check to see if p_decoder->p_building_mgt gets created from the call to dvbpsi_atsc_NewMGT. The check is as follows:</div>
<div><br></div><div><div>if (p_decoder->p_building_mgt)</div><div> return false;</div><div><br></div><div>Shouldn't it be this:</div><div><br></div><div><div>if (!p_decoder->p_building_mgt)</div><div> return false;</div>
</div><div><br></div></div></div></blockquote><div> </div><div>indeed, I quickly checked 2 other ATSC table and they have the same problem.<br>I guess it refers to all ATSC tables. Could you prepare a patch for all ATSC tables and properly test it?<br>
<br></div><div>I do not have ATSC sources, so cannot test.<br><br></div><div>Kind regards,<br></div><div><br>Jean-Paul Saman.<br></div></div><br></div></div>
</blockquote></div><br></div></body></html>