<div dir="ltr">Mike,<br><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Dec 25, 2013 at 5:20 AM, Michael Krufky <span dir="ltr"><<a href="mailto:mkrufky@linuxtv.org" target="_blank">mkrufky@linuxtv.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Jean-Paul,<br>
<br>
After updating my code to use the latest libdvbpsi, I found a nasty<br>
crash when processing ETT tables... Turns out that libdvbpsi is<br>
memcpy'ing the etm data to a pointer that hasn't been allocated!<br>
<br>
Please either apply the included patch or merge it via the pull request<br>
below.<br>
<br>
Happy Holidays & Best regards,<br>
<br>
Michael Krufky<br></blockquote><div><br></div><div>I already had a fix for this in my test tree and did not merge this one.<br><br></div><div>If you feel my solutions is wrong, then do not hesitate to correct it.<br><br>
Kind regards,<br><br>Jean-Paul Saman<br><br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The following changes since commit<br>
4037adea3581059ec7e4253747192868198b6e6b:<br>
<br>
Merge branch 'branch/1.1.0-bugfix' of git.m2x.eu:libdvbpsi<br>
(2013-11-05 09:24:30 +0100)<br>
<br>
are available in the git repository at:<br>
<br>
<br>
<a href="https://github.com/mkrufky/libdvbpsi.git" target="_blank">https://github.com/mkrufky/libdvbpsi.git</a> atsc-ett-bugfix<br>
<br>
for you to fetch changes up to 1c5dc1d40f692aaf6a6f4687bdeeef22848cbc9c:<br>
<br>
atsc_ett: fix bug: nobody allocated p_etm_data (2013-12-24 23:11:23<br>
-0500)<br>
<br>
----------------------------------------------------------------<br>
Michael Krufky (1):<br>
atsc_ett: fix bug: nobody allocated p_etm_data<br>
<br>
src/tables/atsc_ett.c | 5 +++++<br>
1 file changed, 5 insertions(+)<br>
<br>
---<br>
<br>
>From 1c5dc1d40f692aaf6a6f4687bdeeef22848cbc9c Mon Sep 17 00:00:00 2001<br>
From: Michael Krufky <<a href="mailto:mkrufky@linuxtv.org">mkrufky@linuxtv.org</a>><br>
Date: Tue, 24 Dec 2013 23:11:23 -0500<br>
Subject: [PATCH] atsc_ett: fix bug: nobody allocated p_etm_data<br>
<br>
Signed-off-by: Michael Krufky <<a href="mailto:mkrufky@linuxtv.org">mkrufky@linuxtv.org</a>><br>
---<br>
src/tables/atsc_ett.c | 5 +++++<br>
1 file changed, 5 insertions(+)<br>
<br>
diff --git a/src/tables/atsc_ett.c b/src/tables/atsc_ett.c<br>
index 2caa446..752637c 100644<br>
--- a/src/tables/atsc_ett.c<br>
+++ b/src/tables/atsc_ett.c<br>
@@ -416,6 +416,11 @@ static void<br>
dvbpsi_atsc_DecodeETTSections(dvbpsi_atsc_ett_t* p_ett,<br>
* decoded table struct. */<br>
if (p_ett->p_etm_data)<br>
abort();<br>
+<br>
+ p_ett->p_etm_data = malloc(i_etm_length);<br>
+ if (!p_ett->p_etm_data)<br>
+ abort();<br>
+<br>
memcpy(p_ett->p_etm_data, p_section->p_payload_start + 5,<br>
i_etm_length); p_ett->i_etm_length = i_etm_length;<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
1.8.1.2<br>
</font></span></blockquote></div><br></div></div>