<div dir="ltr"><div><div>Patch applied, thanks for contributing.<br><br><br></div>Kind regards<br><br></div>Jean-Paul Saman</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 4, 2015 at 11:18 PM, Daniel Kamil Kozar <span dir="ltr"><<a href="mailto:dkk089@gmail.com" target="_blank">dkk089@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The address of a local variable instead of its actual value was passed<br>
to memcpy. As a result, the actual memory referenced by the<br>
p_additional_info pointer was never written to when decoding the<br>
descriptor. Analogous issue occurred when generating.<br>
---<br>
 src/descriptors/dr_7c.c | 4 ++--<br>
 1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/descriptors/dr_7c.c b/src/descriptors/dr_7c.c<br>
index f51acb4..41d1d8a 100644<br>
--- a/src/descriptors/dr_7c.c<br>
+++ b/src/descriptors/dr_7c.c<br>
@@ -257,7 +257,7 @@ dvbpsi_aac_dr_t *dvbpsi_DecodeAACDr(dvbpsi_descriptor_t *p_descriptor)<br>
<br>
         uint8_t i_data = p_decoded->b_type ? 3 : 2;<br>
         uint8_t *p = &p_descriptor->p_data[i_data];<br>
-        memcpy(&p_decoded->p_additional_info, p, i_info_length);<br>
+        memcpy(p_decoded->p_additional_info, p, i_info_length);<br>
     }<br>
<br>
     p_descriptor->p_decoded = (void*)p_decoded;<br>
@@ -292,7 +292,7 @@ dvbpsi_descriptor_t *dvbpsi_GenAACDr(dvbpsi_aac_dr_t *p_decoded, bool b_duplicat<br>
     if (p_descriptor->i_length > 1)<br>
     {<br>
         uint8_t *p = &p_descriptor->p_data[p_decoded->b_type ? 3 : 2];<br>
-        memcpy(&p, p_decoded->p_additional_info, p_decoded->i_additional_info_length);<br>
+        memcpy(p, p_decoded->p_additional_info, p_decoded->i_additional_info_length);<br>
     }<br>
<br>
     if (b_duplicate)<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.3.1<br>
<br>
_______________________________________________<br>
libdvbpsi-devel mailing list<br>
<a href="mailto:libdvbpsi-devel@videolan.org">libdvbpsi-devel@videolan.org</a><br>
<a href="https://mailman.videolan.org/listinfo/libdvbpsi-devel" target="_blank">https://mailman.videolan.org/listinfo/libdvbpsi-devel</a><br>
</font></span></blockquote></div><br></div>