[vlc-commits] commit: Qt4: Cosmetics about ClickLineEdit, QVLCFramelessButton ( Hugo Beauzée-Luyssen )

[git at videolan.org]

vlc | branch: master | Hugo Beauzée-Luyssen <beauze.h at gmail.com> | Thu Jul  8 16:11:56 2010 +0200| [0a47447d5ca81575c143e9a1c24da31ef38d323d] | committer: Jean-Baptiste Kempf 

Qt4: Cosmetics about ClickLineEdit, QVLCFramelessButton

This removes useless member, useless parameter, useless empty dtor, and
adds a missing reference.

Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=0a47447d5ca81575c143e9a1c24da31ef38d323d
---

 modules/gui/qt4/util/customwidgets.cpp |    2 +-
 modules/gui/qt4/util/customwidgets.hpp |    4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/modules/gui/qt4/util/customwidgets.cpp b/modules/gui/qt4/util/customwidgets.cpp
index 5b460c3..00e0296 100644
--- a/modules/gui/qt4/util/customwidgets.cpp
+++ b/modules/gui/qt4/util/customwidgets.cpp
@@ -109,7 +109,7 @@ QVLCFramelessButton::QVLCFramelessButton( QWidget *parent )
     setSizePolicy( QSizePolicy::Preferred, QSizePolicy::Preferred );
 }
 
-void QVLCFramelessButton::paintEvent( QPaintEvent * event )
+void QVLCFramelessButton::paintEvent( QPaintEvent * )
 {
     QPainter painter( this );
     QPixmap pix = icon().pixmap( size() );
diff --git a/modules/gui/qt4/util/customwidgets.hpp b/modules/gui/qt4/util/customwidgets.hpp
index 13e685f..64d08dd 100644
--- a/modules/gui/qt4/util/customwidgets.hpp
+++ b/modules/gui/qt4/util/customwidgets.hpp
@@ -45,9 +45,8 @@ class ClickLineEdit : public QLineEdit
     Q_PROPERTY( QString clickMessage READ clickMessage WRITE setClickMessage )
 public:
     ClickLineEdit( const QString &msg, QWidget *parent );
-    virtual ~ClickLineEdit() {};
     void setClickMessage( const QString &msg );
-    QString clickMessage() const { return mClickMessage; }
+    const QString& clickMessage() const { return mClickMessage; }
     virtual void setText( const QString& txt );
 protected:
     virtual void paintEvent( QPaintEvent *e );
@@ -83,7 +82,6 @@ private:
     void setMessageVisible( bool on );
     QVLCFramelessButton   *clearButton;
     bool message;
-    QLabel *msg;
 
 public slots:
     void clear();