[vlc-commits] Direct3D: do not leak textures when recycling them

Felix Abecassis git at videolan.org
Thu Feb 13 11:29:32 CET 2014


vlc | branch: master | Felix Abecassis <felix.abecassis at gmail.com> | Thu Feb 13 10:19:05 2014 +0100| [e25184612eee912c8ef329cf1ad7a0a2b76d96ba] | committer: Jean-Baptiste Kempf

Direct3D: do not leak textures when recycling them

If several textures from the cache (i.e. used during the previous
call) are matching we invalidate all of them but only keep the last
one. We therefore lose all references to the other ones.

Close #10248

Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=e25184612eee912c8ef329cf1ad7a0a2b76d96ba
---

 modules/video_output/msw/direct3d.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/modules/video_output/msw/direct3d.c b/modules/video_output/msw/direct3d.c
index 6b33bf4..4b3aae8 100644
--- a/modules/video_output/msw/direct3d.c
+++ b/modules/video_output/msw/direct3d.c
@@ -1439,6 +1439,7 @@ static void Direct3DImportSubpicture(vout_display_t *vd,
 #endif
                 *d3dr = *cache;
                 memset(cache, 0, sizeof(*cache));
+                break;
             }
         }
         if (!d3dr->texture) {



More information about the vlc-commits mailing list