[vlc-commits] [Git][videolan/vlc][master] libplacebo: utils: fix unwanted fall-through

Steve Lhomme (@robUx4) gitlab at videolan.org
Wed Aug 2 07:34:29 UTC 2023



Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
e1ebbce7 by Alexandre Janniaux at 2023-08-02T06:59:51+00:00
libplacebo: utils: fix unwanted fall-through

Those cases are supposed to assign different values, but are overriding
each other because of the fall-through.

Regression from d9eca774fc50df3af2404faf2ccbd2d15222b43f when the
conditional PL_API < 269 is verified.

- - - - -


1 changed file:

- modules/video_output/libplacebo/utils.c


Changes:

=====================================
modules/video_output/libplacebo/utils.c
=====================================
@@ -599,9 +599,9 @@ void vlc_placebo_ColorMapParams(vlc_object_t *obj, const char *prefix,
     case GAMUT_RELATIVE:    params->intent = PL_INTENT_RELATIVE_COLORIMETRIC; break;
     case GAMUT_SATURATION:  params->intent = PL_INTENT_SATURATION; break;
     case GAMUT_ABSOLUTE:    params->intent = PL_INTENT_ABSOLUTE_COLORIMETRIC; break;
-    case GAMUT_DESATURATE:  params->gamut_mode = PL_GAMUT_DESATURATE;
-    case GAMUT_DARKEN:      params->gamut_mode = PL_GAMUT_DARKEN;
-    case GAMUT_WARN:        params->gamut_mode = PL_GAMUT_WARN;
+    case GAMUT_DESATURATE:  params->gamut_mode = PL_GAMUT_DESATURATE; break;
+    case GAMUT_DARKEN:      params->gamut_mode = PL_GAMUT_DARKEN; break;
+    case GAMUT_WARN:        params->gamut_mode = PL_GAMUT_WARN; break;
     case GAMUT_LINEAR:      break; // unsupported
 #endif
     }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/e1ebbce7d1a253e0b7bd5ee84b41aff9c9eddef9

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/e1ebbce7d1a253e0b7bd5ee84b41aff9c9eddef9
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance


More information about the vlc-commits mailing list