[vlc-commits] [Git][videolan/vlc][master] 2 commits: xcb/render: disable dead code

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
c7d97f22 by Steve Lhomme at 2023-08-31T07:45:16+00:00
xcb/render: disable dead code

ParseFormat() can only be called with depth at 32.

- - - - -
af3398dc by Steve Lhomme at 2023-08-31T07:45:16+00:00
xcb/render: don't set a mask on RGB+alpha chromas

All 32 bits chromas use RGB+alpha.

We have to reset the mask in case there was one on the input.

- - - - -


1 changed file:

- modules/video_output/xcb/render.c


Changes:

=====================================
modules/video_output/xcb/render.c
=====================================
@@ -468,6 +468,7 @@ static vlc_fourcc_t ParseFormat(const xcb_setup_t *setup,
 #endif
             }
             break;
+#if 0
         /* TODO 30 bits HDR */
         case 24:
             if (bpp == 32 && d->red_mask == 0xff && d->green_mask == 0xff
@@ -487,6 +488,7 @@ static vlc_fourcc_t ParseFormat(const xcb_setup_t *setup,
              && d->blue_mask == 0x1f && d->alpha_mask == 0x00)
                 return VLC_CODEC_RGB15;
             break;
+#endif
     }
 
     return 0;
@@ -623,9 +625,12 @@ static int Open(vout_display_t *vd,
             continue;
 
         fmtp->i_chroma = chroma;
+        fmtp->i_rmask = fmtp->i_gmask = fmtp->i_bmask = 0;
+#if 0
         fmtp->i_rmask = ((uint32_t)d->red_mask) << d->red_shift;
         fmtp->i_gmask = ((uint32_t)d->green_mask) << d->green_shift;
         fmtp->i_bmask = ((uint32_t)d->blue_mask) << d->blue_shift;
+#endif
         sys->format.argb = pic_fmt->id;
         visual = vid;
     }



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/214f8fc46ea126f84bc1d0697a916000f4f7a6de...af3398dc11d9737f0026099eb5f598d24e63644c

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/214f8fc46ea126f84bc1d0697a916000f4f7a6de...af3398dc11d9737f0026099eb5f598d24e63644c
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance