[vlc-commits] [Git][videolan/vlc][master] 18 commits: input_internal: remove unused headers

Wed Jul 5 14:11:11 UTC 2023

Steve Lhomme pushed to branch master at VideoLAN / VLC

Commits:
75f375f0 by Steve Lhomme at 2023-07-05T13:47:59+00:00
input_internal: remove unused headers

- - - - -
1b2548cd by Steve Lhomme at 2023-07-05T13:47:59+00:00
input/access: remove unused/redundant headers

- - - - -
a8de50c3 by Steve Lhomme at 2023-07-05T13:47:59+00:00
demux: mkv: remove unused/redundant includes

- - - - -
8b986b26 by Steve Lhomme at 2023-07-05T13:47:59+00:00
core: explicitly include windows.h when needed

- - - - -
6f992b75 by Steve Lhomme at 2023-07-05T13:47:59+00:00
modules: explicitly include windows.h when needed

- - - - -
fa5c1866 by Steve Lhomme at 2023-07-05T13:47:59+00:00
demux: json: don't include config.h in grammar files

We don't use any VLC code in there, only a few standard headers.

- - - - -
ff5d0011 by Steve Lhomme at 2023-07-05T13:47:59+00:00
modules: for the WINAPI_FAMILY before including config.h

vlc_fixups.h may include some header that define different things depending
on the WINAPI_FAMILY (processthreadsapi).

- - - - -
3e56bf5f by Steve Lhomme at 2023-07-05T13:47:59+00:00
vlc_fixup: include processthreadsapi to get GetCurrentProcessId() on Windows

- - - - -
483463ca by Steve Lhomme at 2023-07-05T13:47:59+00:00
vlc_common: don't include windows.h

Code doing Windows specific calls need to do the include themselves.

We should not always include windows.h because it should not be included before
winsock headers.

- - - - -
33108ccf by Steve Lhomme at 2023-07-05T13:47:59+00:00
netconf: remove unneeded windows.h include

This would be needed if we were using the registry.

- - - - -
b1a36d58 by Steve Lhomme at 2023-07-05T13:47:59+00:00
vlc_tick: include vlc_config to get CLOCK_FREQ

It is sometimes included without vlc_common.h.

- - - - -
9ca790a6 by Steve Lhomme at 2023-07-05T13:47:59+00:00
win32: thread: use the proper signature for DllMain

_DECL_DLLMAIN is needed to get the signature of DllMain. But depending
whether windows.h is included the signature differs (WINAPI, HANDLE, etc).
This is only the case in mingw-w64. In the Windows SDK there's only the
definition without the fancy types.

We need to include process.h before windows.h so we have the same definition
as the Windows SDK.

- - - - -
f1d341bc by Steve Lhomme at 2023-07-05T13:47:59+00:00
access: wasapi: use the proper signature for DllMain

_DECL_DLLMAIN is needed to get the signature of DllMain. But depending
whether windows.h is included the signature differs (WINAPI, HANDLE, etc).
This is only the case in mingw-w64. In the Windows SDK there's only the
definition without the fancy types.

We need to include process.h before windows.h so we have the same definition
as the Windows SDK.

- - - - -
6f21fd38 by Steve Lhomme at 2023-07-05T13:47:59+00:00
vlc_charset: include windows.h when we need it

- - - - -
174f484f by Steve Lhomme at 2023-07-05T13:47:59+00:00
core: move vlc_charset.h include after winsock including headers

vlc_charset includes windows.h which is supposed to be included *after*
winsock.h/winsock2.h.

- - - - -
5cd8b258 by Steve Lhomme at 2023-07-05T13:47:59+00:00
modules: move vlc_charset.h include after winsock including headers

vlc_charset includes windows.h which is supposed to be included *after*
winsock.h/winsock2.h.

- - - - -
9e6b5694 by Steve Lhomme at 2023-07-05T13:47:59+00:00
skins2: move vlc_charset usage in respective files

Only needed once for Windows and once for OS/2.

Only needed a couple of times for Windows and once for OS/2.

- - - - -
7a198cd3 by Steve Lhomme at 2023-07-05T13:47:59+00:00
qt: reorder includes to include windows.h later

Or rather vlc_cxx_helpers.hpp earlier which often includes winsock.

- - - - -

30 changed files:

- include/vlc_charset.h
- include/vlc_common.h
- include/vlc_fixups.h
- include/vlc_tick.h
- modules/access/file.c
- modules/access/mms/mmstu.c
- modules/access/screen/win32.c
- modules/access/wasapi.c
- modules/codec/avcodec/d3d11va.c
- modules/codec/avcodec/directx_va.c
- modules/codec/mft.cpp
- modules/control/globalhotkeys/win32.c
- modules/demux/json/grammar.y
- modules/demux/json/lexicon.l
- modules/demux/mkv/matroska_segment.cpp
- modules/demux/mkv/mkv.hpp
- modules/gui/qt/maininterface/compositor_dcomp.hpp
- modules/gui/qt/maininterface/compositor_dcomp_acrylicsurface.cpp
- modules/gui/qt/maininterface/compositor_dcomp_acrylicsurface.hpp
- modules/gui/qt/maininterface/compositor_dummy.cpp
- modules/gui/qt/player/player_controller.hpp
- modules/gui/qt/qt.cpp
- modules/gui/qt/widgets/native/csdthemeimage.cpp
- modules/gui/skins2/src/skin_common.hpp
- modules/gui/skins2/src/theme_loader.cpp
- modules/gui/skins2/win32/win32_dragdrop.cpp
- modules/gui/skins2/win32/win32_factory.cpp
- modules/gui/skins2/win32/win32_popup.cpp
- modules/gui/skins2/win32/win32_timer.hpp
- modules/services_discovery/upnp-wrapper.hpp

The diff was not included because it is too large.

View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/70e897847cc6d94ba349b8f12ce7fb2c68c414d3...7a198cd3864b073440e2ed117902a877db7f8477

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/70e897847cc6d94ba349b8f12ce7fb2c68c414d3...7a198cd3864b073440e2ed117902a877db7f8477
You're receiving this email because of your account on code.videolan.org.

VideoLAN code repository instance