[vlc-commits] [Git][videolan/vlc][master] Revert "qml: fix segmentation fault on component destruction"

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
a4f29f92 by Fatih Uzunoglu at 2023-07-08T21:46:50+00:00
Revert "qml: fix segmentation fault on component destruction"

This reverts commit f3e0752f50652e3af7b40ed35978b9a4d457c2f5.

- - - - -


1 changed file:

- modules/gui/qt/widgets/qml/KeyNavigableTableView.qml


Changes:

=====================================
modules/gui/qt/widgets/qml/KeyNavigableTableView.qml
=====================================
@@ -155,8 +155,6 @@ FocusScope {
         availableRowWidthUpdater.enqueueUpdate()
     }
 
-    Component.onDestruction: _qtAvoidSectionUpdate()
-
     on_CurrentAvailableRowWidthChanged: if (_ready) availableRowWidthUpdater.enqueueUpdate()
 
     // Functions
@@ -184,31 +182,6 @@ FocusScope {
 
     // Private
 
-    function _qtAvoidSectionUpdate() {
-        // Qt SEG. FAULT WORKAROUND
-
-        // There exists a Qt bug that tries to access null
-        // pointer while updating sections. Qt does not
-        // check if `QQmlEngine::contextForObject(sectionItem)->parentContext()`
-        // is null and when it's null which might be the case for
-        // views during destruction it causes segmentation fault.
-
-        // As a workaround, when section delegate is set to null
-        // during destruction, Qt does not proceed with updating
-        // the sections so null pointer access is avoided. Updating
-        // sections during destruction should not make sense anyway.
-
-        // Setting section delegate to null seems to has no
-        // negative impact and safely could be used as a fix.
-        // However, the problem lying beneath prevails and
-        // should be taken care of sooner than later.
-
-        // Affected Qt versions are 5.11.3, and 5.15.2 (not
-        // limited).
-
-        section.delegate = null
-    }
-
     // Childs
 
     Timer {



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/a4f29f92d165116843b3c82d415ce5e4b136dbea

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/a4f29f92d165116843b3c82d415ce5e4b136dbea
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance