[vlc-commits] [Git][videolan/vlc][master] qml: remove unused qt_intf_t from SVGColorImageImageProvider

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
de40a3a6 by Steve Lhomme at 2023-07-20T07:51:13+00:00
qml: remove unused qt_intf_t from SVGColorImageImageProvider

Fixes a warning.

- - - - -


3 changed files:

- modules/gui/qt/maininterface/mainui.cpp
- modules/gui/qt/util/color_svg_image_provider.cpp
- modules/gui/qt/util/color_svg_image_provider.hpp


Changes:

=====================================
modules/gui/qt/maininterface/mainui.cpp
=====================================
@@ -172,7 +172,7 @@ bool MainUI::setup(QQmlEngine* engine)
     }
 
     SingletonRegisterHelper<EffectsImageProvider>::setInstance(new EffectsImageProvider(engine));
-    engine->addImageProvider(QStringLiteral("svgcolor"), new SVGColorImageImageProvider(m_intf));
+    engine->addImageProvider(QStringLiteral("svgcolor"), new SVGColorImageImageProvider());
 
     m_component  = new QQmlComponent(engine, QStringLiteral("qrc:/main/MainInterface.qml"), QQmlComponent::PreferSynchronous, engine);
     if (m_component->isLoading())


=====================================
modules/gui/qt/util/color_svg_image_provider.cpp
=====================================
@@ -189,12 +189,6 @@ private:
 };
 }
 
-SVGColorImageImageProvider::SVGColorImageImageProvider(qt_intf_t* p_intf)
-    : QQuickAsyncImageProvider()
-    , m_intf(p_intf)
-{
-}
-
 QQuickImageResponse* SVGColorImageImageProvider::requestImageResponse(const QString& id, const QSize& requestedSize)
 {
     QUrl url {id};


=====================================
modules/gui/qt/util/color_svg_image_provider.hpp
=====================================
@@ -24,17 +24,10 @@
 #include <QString>
 #include <QUrlQuery>
 
-struct qt_intf_t;
-
 class SVGColorImageImageProvider: public QQuickAsyncImageProvider
 {
 public:
-    SVGColorImageImageProvider(qt_intf_t *p_intf);
-
     QQuickImageResponse* requestImageResponse(const QString &id, const QSize &requestedSize) override;
-
-private:
-    qt_intf_t *m_intf = nullptr;
 };
 
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/de40a3a601cb92726b1ee9410490dea8a6c4bdd0

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/de40a3a601cb92726b1ee9410490dea8a6c4bdd0
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance