[vlc-commits] [Git][videolan/vlc][master] 4 commits: qml: don't set ScrollBar policy in EditorDNDView

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
dc3f7e8f by Fatih Uzunoglu at 2023-07-20T21:39:48+00:00
qml: don't set ScrollBar policy in EditorDNDView

- - - - -
31db6e40 by Fatih Uzunoglu at 2023-07-20T21:39:48+00:00
qml: don't set ScrollBar policy in ToolbarEditorButtonList

- - - - -
fb01d8c7 by Fatih Uzunoglu at 2023-07-20T21:39:48+00:00
qml: fix broken ScrollBar logic in KeyNavigableListView

These are meant to change the policy, not visibility

- - - - -
cb94447a by Fatih Uzunoglu at 2023-07-20T21:39:48+00:00
qml: don't set active of ScrollBar in OverlayMenu

- - - - -


4 changed files:

- modules/gui/qt/dialogs/toolbar/qml/EditorDNDView.qml
- modules/gui/qt/dialogs/toolbar/qml/ToolbarEditorButtonList.qml
- modules/gui/qt/widgets/qml/KeyNavigableListView.qml
- modules/gui/qt/widgets/qml/OverlayMenu.qml


Changes:

=====================================
modules/gui/qt/dialogs/toolbar/qml/EditorDNDView.qml
=====================================
@@ -43,7 +43,6 @@ ListView {
 
     ScrollBar.horizontal: ScrollBar {
         id: scrollBar
-        policy: playerBtnDND.contentWidth > playerBtnDND.width ? ScrollBar.AlwaysOn : ScrollBar.AsNeeded
     }
 
     remove: Transition {


=====================================
modules/gui/qt/dialogs/toolbar/qml/ToolbarEditorButtonList.qml
=====================================
@@ -32,7 +32,7 @@ GridView {
 
     clip: true
 
-    ScrollBar.vertical: ScrollBar { policy: ScrollBar.AlwaysOn }
+    ScrollBar.vertical: ScrollBar { }
     model: PlayerControlbarControls.controlList.length
 
     currentIndex: -1


=====================================
modules/gui/qt/widgets/qml/KeyNavigableListView.qml
=====================================
@@ -84,8 +84,8 @@ FadingEdgeListView {
     //key navigation is reimplemented for item selection
     keyNavigationEnabled: false
 
-    ScrollBar.vertical: ScrollBar { id: scroll_id; visible: root.contentHeight > root.height }
-    ScrollBar.horizontal: ScrollBar { visible: root.contentWidth > root.width }
+    ScrollBar.vertical: ScrollBar { id: scroll_id }
+    ScrollBar.horizontal: ScrollBar { }
 
     highlightMoveDuration: 300 //ms
     highlightMoveVelocity: 1000 //px/s


=====================================
modules/gui/qt/widgets/qml/OverlayMenu.qml
=====================================
@@ -135,7 +135,7 @@ FocusScope {
             anchors.topMargin: root.topPadding
             anchors.bottomMargin: root.bottomPadding
 
-            ScrollBar.vertical: ScrollBar { id: scrollBar; active: true }
+            ScrollBar.vertical: ScrollBar { id: scrollBar }
 
             focus: true
 



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/cb97a80815e17bcb6632c1b1e59685cd952a90cd...cb94447a80b5425a28262e85346fb09eb9176894

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/cb97a80815e17bcb6632c1b1e59685cd952a90cd...cb94447a80b5425a28262e85346fb09eb9176894
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance