[vlc-commits] [Git][videolan/vlc][master] 2 commits: vout_subpictures: check the stop value was set when using subpicture fading

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
6971fd28 by Steve Lhomme at 2024-04-10T09:24:12+00:00
vout_subpictures: check the stop value was set when using subpicture fading

We can't compute a fade ratio without this.

- - - - -
866cab56 by Steve Lhomme at 2024-04-10T09:24:12+00:00
vout_subpictures: check the stop value is usable when fading

If stop is equal to start, fade_start equals start, which ends up with a division by zero.

- - - - -


1 changed file:

- src/video_output/vout_subpictures.c


Changes:

=====================================
src/video_output/vout_subpictures.c
=====================================
@@ -1278,6 +1278,8 @@ static struct subpicture_region_rendered *SpuRenderRegion(spu_t *spu,
     dst->place.height = region_fmt.i_visible_height;
     int fade_alpha = 255;
     if (subpic->b_fade) {
+        assert(subpic->i_stop != VLC_TICK_INVALID);
+        assert(subpic->i_stop > subpic->i_start);
         vlc_tick_t fade_start = subpic->i_start + 3 * (subpic->i_stop - subpic->i_start) / 4;
 
         if (fade_start <= render_date && fade_start < subpic->i_stop)



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/d6846d458b4e7505de3b3dd03dd4888b9fc7648a...866cab56be3be8bd95f63087ae0fe6005c605954

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/d6846d458b4e7505de3b3dd03dd4888b9fc7648a...866cab56be3be8bd95f63087ae0fe6005c605954
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance