[vlc-commits] [Git][videolan/vlc][master] qml: Ctrl+L shortcut to open the playlist view now works the first time

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
62aaef36 by Ash V at 2024-04-13T07:37:40+00:00
qml: Ctrl+L shortcut to open the playlist view now works the first time

Added 'updatePlaylistVisible' transition in the 'fsmForceHidden' FSMState of the PlayerPlaylistVisibilityFSM.qml.

Fixes Issue: #28500

- - - - -


2 changed files:

- modules/gui/qt/player/qml/Player.qml
- modules/gui/qt/player/qml/PlayerPlaylistVisibilityFSM.qml


Changes:

=====================================
modules/gui/qt/player/qml/Player.qml
=====================================
@@ -284,8 +284,9 @@ FocusScope {
         topMargin: VLCStyle.applicationVerticalMargin
         sideMargin: VLCStyle.applicationHorizontalMargin
 
-        textWidth: (MainCtx.playlistVisible) ? rootPlayer.width - playlistpopup.width
-                                             : rootPlayer.width
+        textWidth: playlistVisibility.isPlaylistVisible
+                 ? rootPlayer.width - playlistpopup.width
+                 : rootPlayer.width
 
         // NOTE: With pinned controls, the top controls are hidden when switching to
         //       fullScreen. Except when resume is visible


=====================================
modules/gui/qt/player/qml/PlayerPlaylistVisibilityFSM.qml
=====================================
@@ -69,9 +69,7 @@ Util.FSM {
 
         transitions: ({
             togglePlaylistVisibility: {
-                action: () => {
-                    MainCtx.playlistVisible = !MainCtx.playlistVisible
-                }
+                action: () => { MainCtx.playlistVisible = !MainCtx.playlistVisible }
             },
             updatePlaylistDocked: {
                 guard: () => MainCtx.playlistDocked,
@@ -106,7 +104,7 @@ Util.FSM {
 
                 transitions: ({
                     updatePlaylistVisible: {
-                        guard: ()=> !MainCtx.playlistVisible,
+                        guard: () => !MainCtx.playlistVisible,
                         target: fsmHidden
                     },
                     togglePlaylistVisibility: {
@@ -130,7 +128,6 @@ Util.FSM {
                     }
                 })
             }
-
         }
 
         Util.FSMState {
@@ -141,10 +138,12 @@ Util.FSM {
                     guard: () => !MainCtx.hasEmbededVideo,
                     target: fsmFollowVisible
                 },
+                updatePlaylistVisible: {
+                    guard: () => MainCtx.playlistVisible,
+                    target: fsmFollowVisible
+                },
                 togglePlaylistVisibility: {
-                    action: () => {
-                        MainCtx.playlistVisible = true
-                    },
+                    action: () => { MainCtx.playlistVisible = true },
                     target: fsmFollowVisible
                 }
             })



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/62aaef36a8f7b24dcf41308a7fb4f05674a298c8

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/62aaef36a8f7b24dcf41308a7fb4f05674a298c8
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance