[vlc-commits] [Git][videolan/vlc][master] 7 commits: qml: use templates as base for combobox

[Jean-Baptiste Kempf (@jbk)]

Jean-Baptiste Kempf pushed to branch master at VideoLAN / VLC


Commits:
e259c039 by Prince Gupta at 2024-04-28T15:29:15+00:00
qml: use templates as base for combobox

- - - - -
665d8cfd by Prince Gupta at 2024-04-28T15:29:15+00:00
qml: use IconLabel for indicator in ComboBox

- - - - -
ff6de187 by Prince Gupta at 2024-04-28T15:29:15+00:00
qml: use appropriate type for label

- - - - -
ad31b9ec by Prince Gupta at 2024-04-28T15:29:15+00:00
qml: use templated ItemDelegate

- - - - -
7cfee7ff by Prince Gupta at 2024-04-28T15:29:15+00:00
qml: use default implicitHeight

- - - - -
ca78bab0 by Prince Gupta at 2024-04-28T15:29:15+00:00
qml: update background for ComboBox

- - - - -
03fd36d7 by Prince Gupta at 2024-04-28T15:29:15+00:00
qml: fix size assignment for combobox in PlaybackSpeed

RowLayout doesn't follow width/height property of children

- - - - -


2 changed files:

- modules/gui/qt/player/qml/PlaybackSpeed.qml
- modules/gui/qt/widgets/qml/ComboBoxExt.qml


Changes:

=====================================
modules/gui/qt/player/qml/PlaybackSpeed.qml
=====================================
@@ -283,8 +283,8 @@ ColumnLayout {
         Widgets.ComboBoxExt {
             id: comboBox
 
-            width: VLCStyle.combobox_width_normal
-            height: VLCStyle.combobox_height_normal
+            Layout.preferredWidth: VLCStyle.combobox_width_normal
+            Layout.preferredHeight: VLCStyle.combobox_height_normal
 
             model: ListModel {}
 


=====================================
modules/gui/qt/widgets/qml/ComboBoxExt.qml
=====================================
@@ -16,6 +16,7 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
  *****************************************************************************/
 import QtQuick
+import QtQuick.Templates as T
 import QtQuick.Controls
 
 import org.videolan.vlc 0.1
@@ -23,11 +24,17 @@ import org.videolan.vlc 0.1
 import "qrc:///style/"
 import "qrc:///widgets/" as Widgets
 
-ComboBox {
+T.ComboBox {
     id: control
 
+    implicitWidth: Math.max(implicitBackgroundWidth + leftInset + rightInset,
+                            implicitContentWidth + spacing + implicitIndicatorWidth + leftPadding + rightPadding)
+    implicitHeight: Math.max(implicitBackgroundHeight + topInset + bottomInset,
+                             implicitContentHeight + topPadding + bottomPadding,
+                             implicitIndicatorHeight + topPadding + bottomPadding)
+
+    padding: VLCStyle.margin_xxsmall
     font.pixelSize: VLCStyle.fontSize_large
-    leftPadding: 5
 
     readonly property ColorContext colorContext: ColorContext {
         id: theme
@@ -46,65 +53,46 @@ ComboBox {
     Keys.priority: Keys.AfterItem
     Keys.onPressed: (event) => Navigation.defaultKeyAction(event)
 
-    delegate: ItemDelegate {
+    delegate: T.ItemDelegate {
         width: control.width
+        height: implicitContentHeight + topPadding + bottomPadding
+        padding: VLCStyle.margin_xsmall
         leftPadding: control.leftPadding
-        background: Item {}
-        contentItem: Text {
+        contentItem: Widgets.ListLabel {
             text: control.textRole ? (Array.isArray(control.model) ? modelData[control.textRole] : model[control.textRole]) : modelData
             color: control.color
-            font: control.font
             elide: Text.ElideRight
             verticalAlignment: Text.AlignVCenter
         }
         highlighted: control.highlightedIndex === index
     }
 
-    indicator: Canvas {
-        id: canvas
-        x: control.width - width - control.rightPadding
+    indicator: Widgets.IconLabel {
+        x: control.width - width - rightPadding
         y: control.topPadding + (control.availableHeight - height) / 2
-        width: 10
-        height: 6
-        contextType: "2d"
-
-        Connections {
-            target: control
-            function onPressedChanged() { canvas.requestPaint() }
-        }
-
-        onPaint: {
-            if (context === null)
-                return
-
-            context.reset();
-            context.moveTo(0, 0);
-            context.lineTo(width, 0);
-            context.lineTo(width / 2, height);
-            context.closePath();
-            context.fillStyle = control.activeFocus ? theme.accent : control.color;
-            context.fill();
-        }
+        font.pixelSize: VLCStyle.icon_normal
+        font.bold: true
+        text: VLCIcons.expand
+        color: control.color
+        verticalAlignment: Text.AlignVCenter
+        horizontalAlignment: Text.AlignHCenter
     }
 
-    contentItem: Text {
-        leftPadding: 5
-        rightPadding: control.indicator.width + control.spacing
+    contentItem: Widgets.ListLabel {
+        rightPadding: control.spacing + control.indicator.width
 
         text: control.displayText
-        font: control.font
         color: control.color
         verticalAlignment: Text.AlignVCenter
         elide: Text.ElideRight
     }
 
-    background: Rectangle {
-        implicitWidth: control.width
-        implicitHeight: control.height
+    background: Widgets.AnimatedBackground {
+        enabled: theme.initialized
         color: control.bgColor
-        border.color: control.borderColor
-        border.width: control.activeFocus ? 2 : 1
-        radius: 2
+        border.color: theme.border
+        border.width: VLCStyle.dp(2, VLCStyle.scale)
+        radius: VLCStyle.dp(2, VLCStyle.scale)
     }
 
     popup: Popup {
@@ -114,7 +102,6 @@ ComboBox {
         z: 100
 
         width: control.width
-        implicitHeight: contentItem.implicitHeight
         padding: 1
 
         contentItem: ListView {



View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/3f42195529cae2302a27ec0e6f0f8cf29658c58f...03fd36d79f8d3cfe0d2591b204b56375da435656

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/3f42195529cae2302a27ec0e6f0f8cf29658c58f...03fd36d79f8d3cfe0d2591b204b56375da435656
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance