[vlc-commits] [Git][videolan/vlc][master] 61 commits: macosx: Add starter VLCLibraryWindowNavigationSidebarContoller

Felix Paul Kühne (@fkuehne) gitlab at videolan.org
Sat Feb 24 13:10:18 UTC 2024 


Felix Paul Kühne pushed to branch master at VideoLAN / VLC


Commits:
d318c6ec by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Add starter VLCLibraryWindowNavigationSidebarContoller

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
f281e2f1 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Add convenience init to set library window in nav sidebar controller

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
cb49d221 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Add starter VLCLibrarySection

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
41d26622 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Move library segment enum to VLCLibrarySegment class

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
80a511a3 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Set display string based on segment type in VLCLibrarySegment

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
d7ba7691 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Define library segments as static array property in VLCLibrarySegment

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
e1b39c6f by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Inherit NSTreeNode in VLCLibrarySegment

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
5e310cf3 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Setup treeController in VLCLibraryWindowNavigationSidebarController

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
78ddde75 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Setup outline view in VLCLibraryWindowNavigationSidebarController

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
1feea852 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Make VLCLibraryWindowNavigationSidebarController the outline view delegate for the sidebar outline view

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
4cbd2ac3 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Instantiate a VLCLibraryWindowNavigationSidebarController in VLCLibraryWindow

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
55a4bd50 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Add navigation sidebar view in VLCLibraryWindow XIB

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
f5fe9628 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Provide image in VLCLibrarySegment

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
78c7e55e by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Bind segment image to cell image view image

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
f0ac2d64 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Provide modern icons on new macOS versions for VLCLibrarySegment

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
8c624022 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Add a starter VLCLibraryWindowSplitViewManager

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
4bd5c670 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Add a XIB-focused VLCLibraryWindowSplitViewController that deals with properly controlling sidebar and sizing behaviours of split view items

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
45a72c4c by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Add view controllers and split view controller for split views

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
b9f051a1 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Add starter VLCLibraryWindowToolbarDelegate

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
52bed69a by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Add convenience init for VLCLibraryWindowToolbarDelegate

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
7e0d654f by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Define split view items divider index in VLCLibraryWindow

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
5ef8a065 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Use the toolbar delegate in VLCLibraryWindow

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
c68eaf6e by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Insert a tracking separater toolbar item in VLCLibraryWindow toolbar

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
d8a9c810 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Replace backing NSVisualEffectView in VLCLibraryWindow in favour of normal NSView

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
13606f62 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Properly handle shouldHideDividerAtIndex in VLCLibraryWindowSplitViewController

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
187615e7 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Allow hiding nav sidebar when video view open

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
93e5beff by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Add toolbar tracker item to VLCLibraryWindow toolbar

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
9dbb18d8 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Enable full size sidebar mode

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
33e3fbc8 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Fix top constraint for playlist sidebar

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
7191801a by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Fix library view content and scroller insets for library window views

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
237b1ad4 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Fix playlist table view title top constraint when switching in and out of main video view

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
0be32724 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Hide navigation sidebar when main video view is open

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
69780d73 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Fix presentation of option bar view

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
8770fc5a by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Treat library segment currently selected as property on VLCLibraryWindow

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
cfe7978c by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Make nav sidebar entries functional

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
7c01955b by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Add a convenience method to the nav sidebar controller to select a specific segment

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
23cbb5cf by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Remove the segmented title control from the main library window

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
a411636e by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Improve sizings of library window sidebars

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
22f8893c by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Hold references of library window and split view controller to each other

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
362ee20d by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Fix playlist sidebar collapsing with new split view controller

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
63cf149e by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Add nav sidebar toggle button in XIB

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
71cd7589 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Add outlet for collapsing nav sidebar

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
8220f2fc by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Fix ordering of toolbar items with new sidebar toggle

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
1cc1ffe1 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Ensure nav sidebar toolbar button and only this button is placed in the sidebar area

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
dfddabe1 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Remove split view delegation from VLCLibraryWindow

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
ef740e92 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosxL: Fix build with removal of segemented title buttons in home view VLCLibraryHomeViewController

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
4296964c by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Integrate Home entry into sidebar

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
14a8df8a by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Fix option bar visibility

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
0d752269 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Fix visibility of songs table header

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
30df5b16 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Add childCount property to VLCLibrarySegment

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
d63b4acf by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Add music subsegments to VLCLibrarySegment

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
ece9d677 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Add music subsegments as music segment children

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
7d0cc057 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Use music sub segment types in audio view controller

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
4d3eb110 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Remove need to pass segment type to media source presenter method in library window

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
6441e1d9 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Add support for new music subsegment types in library window

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
cf50feb0 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Remove option bar view and audio library segmented control

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
5da02fde by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Fix placeholder image index in audio view controller

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
0eeff635 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Fix crash caused on library window reopen

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
811ebc45 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Fix setting of list vs grid view mode on music views

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
e0da88d4 by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Ensure selectSegment actually sets library segment on library window

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -
7817030d by Claudio Cambra at 2024-02-24T12:55:04+00:00
macosx: Fix segment selection in navigation sidebar upon library window startup restoration

Signed-off-by: Claudio Cambra <developer at claudiocambra.com>

- - - - -


18 changed files:

- extras/package/macosx/VLC.xcodeproj/project.pbxproj
- modules/gui/macosx/Makefile.am
- modules/gui/macosx/UI/VLCLibraryWindow.xib
- + modules/gui/macosx/library/VLCLibrarySegment.h
- + modules/gui/macosx/library/VLCLibrarySegment.m
- modules/gui/macosx/library/VLCLibraryUIUnits.h
- modules/gui/macosx/library/VLCLibraryUIUnits.m
- modules/gui/macosx/library/VLCLibraryWindow.h
- modules/gui/macosx/library/VLCLibraryWindow.m
- modules/gui/macosx/library/VLCLibraryWindowController.m
- + modules/gui/macosx/library/VLCLibraryWindowNavigationSidebarController.h
- + modules/gui/macosx/library/VLCLibraryWindowNavigationSidebarController.m
- + modules/gui/macosx/library/VLCLibraryWindowSplitViewController.h
- + modules/gui/macosx/library/VLCLibraryWindowSplitViewController.m
- + modules/gui/macosx/library/VLCLibraryWindowToolbarDelegate.h
- + modules/gui/macosx/library/VLCLibraryWindowToolbarDelegate.m
- modules/gui/macosx/library/audio-library/VLCLibraryAudioViewController.h
- modules/gui/macosx/library/audio-library/VLCLibraryAudioViewController.m


The diff was not included because it is too large.


View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/28a2317047f8970a57b6f5527de7190f345da884...7817030df4cf542363e4cf07a5c8716dc7c2a1b0

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/compare/28a2317047f8970a57b6f5527de7190f345da884...7817030df4cf542363e4cf07a5c8716dc7c2a1b0
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance

More information about the vlc-commits mailing list