[vlc-commits] [Git][videolan/vlc][master] test: opengl: fix duplicated assignment

[Steve Lhomme (@robUx4)]

Steve Lhomme pushed to branch master at VideoLAN / VLC


Commits:
908d8998 by Alexandre Janniaux at 2024-03-20T07:34:12+00:00
test: opengl: fix duplicated assignment

The duplicated assignment is UB and leads to the den part being
uninitialized.

Introduced in 83181fa907466663a504b8fd2e5e77978ffff20e.

- - - - -


1 changed file:

- test/modules/video_output/opengl/sub_renderer.c


Changes:

=====================================
test/modules/video_output/opengl/sub_renderer.c
=====================================
@@ -184,8 +184,8 @@ static void test_opengl_offscreen(
     p_region->place.width  = picture->format.i_visible_width;
     p_region->place.height = picture->format.i_visible_height;
     p_region->i_alpha = 255;
-    p_region->zoom_h.num = p_region->zoom_h.num = 1;
-    p_region->zoom_v.num = p_region->zoom_v.num = 1;
+    p_region->zoom_h.num = p_region->zoom_h.den = 1;
+    p_region->zoom_v.num = p_region->zoom_h.den = 1;
     vlc_vector_push( &subpicture->regions, p_region );
 
     ret = vlc_gl_sub_renderer_Prepare(sr, subpicture);



View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/908d899866e099775fa8bb09f3b7a8687daf6374

-- 
View it on GitLab: https://code.videolan.org/videolan/vlc/-/commit/908d899866e099775fa8bb09f3b7a8687daf6374
You're receiving this email because of your account on code.videolan.org.


VideoLAN code repository instance