[vlc-devel] [PATCH] v4l2 userptr fix

Richard Hosking richard at hovis.net
Thu Oct 11 15:45:16 CEST 2007


Just noticed something in my patch.  I am using
'memalign' as the reference example does.  ie:-

new_buffer = memalign( page_size, buffer_size );

Is this correct usage in VLC regarding
portability?  I notice we have a 'vlc_memalign'
function which maybe I should be using instead?

Richard.

Richard Hosking wrote:
> Userptr IO buffers need to be aligned according to
> the V4L2 reference capture c example (which has
> been updated with this recently).
> 
> Also, the reference program has the device close
> operations after the 'free' calls so they have
> been moved.
> 
> This fixes the issue I was having with my device
> crashing vlc on close.
> 
> Also fixed a typo in an error message and renamed
> a local function which was badly named by me.
> 
> Richard.
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel



More information about the vlc-devel mailing list