[vlc-devel] [PATCH] GSoC 2008 Test Patch

[Rémi Denis-Courmont]

Le samedi 12 avril 2008, Justin Lin a écrit :
> diff --git a/modules/gui/qt4/main_interface.cpp
> b/modules/gui/qt4/main_interface.cpp
> index 030ec42..062888e 100644
> --- a/modules/gui/qt4/main_interface.cpp
> +++ b/modules/gui/qt4/main_interface.cpp
> @@ -1181,6 +1181,7 @@ void MainInterface::toggleFullScreen( void )
>      if( isFullScreen() )
>          showNormal();
>      else
> +        MessageBox(0, "Patch Test", "Entering full screen mode...",
> 0) showFullScreen();
>  }

Will break compilation on non-Win32 platform. On Win32, you would 
probably need to include <windows.h> explicitly. Even then, the patch 
does not abide by C syntax, and will not compile (or I am missing 
something).

Finally, I don't quite understand the point anyway.

Regards,

-- 
Rémi Denis-Courmont
http://www.remlab.net/