[vlc-devel] commit: Update comments. (Jean-Baptiste Kempf )

git version control git at videolan.org
Mon Aug 25 09:32:02 CEST 2008


vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Mon Aug 25 00:30:18 2008 -0700| [87219a2be79871310f822d6aba54985553a8e1d9] | committer: Jean-Baptiste Kempf 

Update comments.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=87219a2be79871310f822d6aba54985553a8e1d9
---

 .../gui/qt4/components/complete_preferences.cpp    |    4 ----
 modules/gui/qt4/dialogs/vlm.cpp                    |    7 +++----
 modules/gui/qt4/input_manager.cpp                  |    3 ---
 modules/gui/qt4/qt4.cpp                            |    3 +--
 4 files changed, 4 insertions(+), 13 deletions(-)

diff --git a/modules/gui/qt4/components/complete_preferences.cpp b/modules/gui/qt4/components/complete_preferences.cpp
index cc85b9c..37d2d64 100644
--- a/modules/gui/qt4/components/complete_preferences.cpp
+++ b/modules/gui/qt4/components/complete_preferences.cpp
@@ -178,8 +178,6 @@ PrefsTree::PrefsTree( intf_thread_t *_p_intf, QWidget *_parent ) :
             /* Create a new TreeWidget */
             QTreeWidgetItem *subcat_item = new QTreeWidgetItem();
             subcat_item->setText( 0, data_sub->name );
-            /* TODO : Choose the image */
-            //subcat_item->setIcon( 0 , XXX );
             subcat_item->setData( 0, Qt::UserRole,
                                   qVariantFromValue( data_sub ) );
             subcat_item->setSizeHint( 0, QSize( -1, ITEM_HEIGHT ) );
@@ -274,10 +272,8 @@ PrefsTree::PrefsTree( intf_thread_t *_p_intf, QWidget *_parent ) :
         module_data->i_type = TYPE_MODULE;
         module_data->psz_name = strdup( module_GetObjName( p_module ) );
         module_data->help.clear();
-        // TODO image
         QTreeWidgetItem *module_item = new QTreeWidgetItem();
         module_item->setText( 0, qtr( module_GetName( p_module, false ) ) );
-        //item->setIcon( 0 , XXX );
         module_item->setData( 0, Qt::UserRole,
                               QVariant::fromValue( module_data) );
         module_item->setSizeHint( 0, QSize( -1, ITEM_HEIGHT ) );
diff --git a/modules/gui/qt4/dialogs/vlm.cpp b/modules/gui/qt4/dialogs/vlm.cpp
index 430296c..c6b013a 100644
--- a/modules/gui/qt4/dialogs/vlm.cpp
+++ b/modules/gui/qt4/dialogs/vlm.cpp
@@ -164,7 +164,7 @@ VLMDialog::~VLMDialog()
 {
     delete vlmWrapper;
 
-   /* FIXME :you have to destroy vlm here to close
+   /* TODO :you have to destroy vlm here to close
     * but we shouldn't destroy vlm here in case somebody else wants it */
     if( p_vlm )
     {
@@ -259,7 +259,7 @@ void VLMDialog::addVLMItem()
     clearWidgets();
 }
 
-// FIXME : VOD are not exported to the file
+/* TODO : VOD are not exported to the file */
 bool VLMDialog::exportVLMConf()
 {
     QString saveVLMConfFileName = QFileDialog::getSaveFileName(
@@ -454,8 +454,7 @@ void VLMDialog::saveModifications()
             break;
            //           vlmObj->
         }
-        vlmObj->update(); /* It should call the correct function is VLMAWidget
-                             is abstract, but I am far from sure... FIXME ? */
+        vlmObj->update();
     }
     clearWidgets();
 }
diff --git a/modules/gui/qt4/input_manager.cpp b/modules/gui/qt4/input_manager.cpp
index 87f7299..1a221fd 100644
--- a/modules/gui/qt4/input_manager.cpp
+++ b/modules/gui/qt4/input_manager.cpp
@@ -571,9 +571,6 @@ MainInputManager::MainInputManager( intf_thread_t *_p_intf )
 
     var_AddCallback( p_intf->p_libvlc, "volume-change", VolumeChanged, this );
 
-    // No necessary, I think TODO REMOVE ME at the end
-    //var_AddCallback( THEPL, "intf-change", ItemChanged, im );
-
     /* Warn our embedded IM about input changes */
     CONNECT( this, inputChanged( input_thread_t * ),
              im, setInput( input_thread_t * ) );
diff --git a/modules/gui/qt4/qt4.cpp b/modules/gui/qt4/qt4.cpp
index 100c002..0811f14 100644
--- a/modules/gui/qt4/qt4.cpp
+++ b/modules/gui/qt4/qt4.cpp
@@ -337,8 +337,7 @@ static void *Init( vlc_object_t *obj )
 #endif
             QSettings::UserScope, "vlc", "vlc-qt-interface" );
 
-    /* Icon setting
-       FIXME: use a bigger icon ? */
+    /* Icon setting */
     if( QDate::currentDate().dayOfYear() >= 354 )
         app->setWindowIcon( QIcon( QPixmap(vlc_christmas_xpm) ) );
     else




More information about the vlc-devel mailing list