[vlc-devel] commit: Remove the brain-damaged video output destruction code ( Rémi Denis-Courmont )

[git version control]

vlc | branch: master | Rémi Denis-Courmont <rdenis at simphalempin.com> | Mon Jun 30 22:57:54 2008 +0300| [9f2fb28d7e4899695ccf5a92a3bba3396ebd2e7f]

Remove the brain-damaged video output destruction code

Fixes crashes, deadlocks and assertions failure with #1650.
One cannot remove object references one does not own.

Reopens #1637.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=9f2fb28d7e4899695ccf5a92a3bba3396ebd2e7f
---

 src/playlist/engine.c |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/src/playlist/engine.c b/src/playlist/engine.c
index 622f29e..93b3bcd 100644
--- a/src/playlist/engine.c
+++ b/src/playlist/engine.c
@@ -193,16 +193,6 @@ static void ObjectGarbageCollector( playlist_t *p_playlist, bool b_force )
     }
 
     vlc_mutex_lock( &p_playlist->gc_lock );
-    /* Remove video outputs when user presses stop: */
-    vlc_list_t *list = vlc_list_find( p_playlist->p_libvlc, VLC_OBJECT_VOUT,
-                                      FIND_CHILD );
-    if( list != NULL )
-    {
-        msg_Dbg( p_playlist, "removing %u vout(s)", list->i_count );
-        for( int i = 0; i < list->i_count; i++)
-            vlc_object_release( list->p_values[i].p_object );
-        vlc_list_release( list );
-    }
     p_playlist->b_cant_sleep = false;
     vlc_mutex_unlock( &p_playlist->gc_lock );
 }