[vlc-devel] commit: Fix a false assertion fail in the Qt4 playlist. ( Rémi Duraffort )

[Rafaël Carré]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Le Mon, 5 May 2008 22:20:04 +0200,
Rémi Duraffort <ivoire at via.ecp.fr> a écrit :

> > > Fix a false assertion fail in the Qt4 playlist.
> > 
> > Which assertion does this fix ? 
> > 
> > > -    COLUMN_END
> > > +    COLUMN_END          = 0x0100
> 
> In modules/gui/qt4/components/playlist/playlist_item.cpp line 114
> assert( i_showflags < COLUMN_END );

shame on me :/

maybe it would be better to compute COLUMN_END in the assertion ?

something like assert( i_showflags < COLUMN_END << 1 - 2 );
I think it's more readable, and avoid needing to update COLUMN_END

- -- 
Rafaël Carré
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIH2+6YWCeGMCv8Q8RAtywAJ0QC6cmkr9hlVZwxsSTO2P/cpHYOACdF6cw
4iUrFYADF+5aHkHZ8mSQ1Rg=
=rcpZ
-----END PGP SIGNATURE-----