[vlc-devel] [PATCH] Properly fix HDTV height for H.264 streams

[Marian Ďurkovič]

On Fri, 3 Oct 2008 18:00:17 +0300, Rémi Denis-Courmont wrote
> Le vendredi 3 octobre 2008 13:14:17 Marian Ďurkovič, vous avez écrit :
> > Hi,
> >
> >   attached please find the patch which ensures proper fixing for
> > broken H.264 HDTV-1080 streams. Unfortunately, even with H.264,
> > some broadcasters still transmit 1088 lines :-(
> 
> If I understand correctly, that's for streams with 1088 lines, with 
> an "already" adjusted aspect ratio, right? I wonder if we should move 
> the warning inside the if() too??

There are actually two things which could be broken.

One of them is number of lines (1088 instead of 1080), another one
is fishy pixel aspect ratio (136:135 instead of 1:1).

When the stream comes from libmpeg2, both are broken.
When the stream comes from ffmpeg's H.264 decoder, PAR is OK, but
number of lines is not.

Thus, the warning about wrong number of lines is at correct place, but we might
consider adding another warning inside the if() for broken PAR.


    With kind regards,

       M.