[vlc-devel] commit: there's no vlc_thread_create(p_helper) (Geoffroy Couprie )

Jean-Baptiste Kempf jb at videolan.org
Wed Sep 17 01:51:34 CEST 2008


DOes this need backport ?

On Tue, Sep 16, 2008 at 02:07:50AM +0200, git version control wrote :
> vlc | branch: master | Geoffroy Couprie <geo.couprie at gmail.com> | Tue Sep 16 02:10:05 2008 +0200| [f2e48db1350361b4b87622f872807a4a6250672e] | committer: Geoffroy Couprie 
> 
> there's no vlc_thread_create(p_helper)
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=f2e48db1350361b4b87622f872807a4a6250672e
> ---
> 
>  src/misc/win32_specific.c |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/src/misc/win32_specific.c b/src/misc/win32_specific.c
> index 5de59a5..84f7dd3 100644
> --- a/src/misc/win32_specific.c
> +++ b/src/misc/win32_specific.c
> @@ -368,16 +368,21 @@ LRESULT CALLBACK WMCOPYWNDPROC( HWND hwnd, UINT uMsg, WPARAM wParam,
>   *****************************************************************************/
>  void system_End( libvlc_int_t *p_this )
>  {
> +    HWND ipcwindow;
>      if( p_this && vlc_global() )
>      {
>          free( vlc_global()->psz_vlcpath );
>          vlc_global()->psz_vlcpath = NULL;
>      }
> +
> +    if( ipcwindow = FindWindow( 0, L"VLC ipc "VERSION ) )
> +    {
> +        SendMessage( ipcwindow, WM_QUIT, 0, 0 );
> +    }
> +
>      if (p_helper && p_helper->p_parent == VLC_OBJECT(p_this) )
>      {
>          /* FIXME: thread-safety... */
> -        SendMessage( NULL, WM_QUIT, 0, 0 );
> -        vlc_thread_join (p_helper);
>          vlc_object_detach (p_helper);
>          vlc_object_release (p_helper);
>          p_helper = NULL;
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> http://mailman.videolan.org/listinfo/vlc-devel

-- 
Best Regards,

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/



More information about the vlc-devel mailing list