[vlc-devel] commit: Avoid variable shadowing ( Rémi Denis-Courmont )

[git version control]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Wed Dec 30 20:17:32 2009 +0200| [a3c6cf071e4eace5ab7e8ca7fed62527d167fe30] | committer: Rémi Denis-Courmont 

Avoid variable shadowing

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=a3c6cf071e4eace5ab7e8ca7fed62527d167fe30
---

 modules/access/mms/mmsh.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/modules/access/mms/mmsh.c b/modules/access/mms/mmsh.c
index 2c2d210..ec0d3e4 100644
--- a/modules/access/mms/mmsh.c
+++ b/modules/access/mms/mmsh.c
@@ -110,19 +110,19 @@ int MMSHOpen( access_t *p_access )
     {
         p_sys->b_proxy = true;
         vlc_UrlParse( &p_sys->proxy, psz_proxy, 0 );
+        free( psz_proxy );
     }
 #ifdef HAVE_GETENV
     else
     {
-        char *psz_proxy = getenv( "http_proxy" );
-        if( psz_proxy && *psz_proxy )
+        const char *http_proxy = getenv( "http_proxy" );
+        if( http_proxy )
         {
             p_sys->b_proxy = true;
-            vlc_UrlParse( &p_sys->proxy, psz_proxy, 0 );
+            vlc_UrlParse( &p_sys->proxy, http_proxy, 0 );
         }
     }
 #endif
-    free( psz_proxy );
 
     if( p_sys->b_proxy )
     {