[vlc-devel] commit: Leave recent items filter empty. (Antoine Cellerier )

Jean-Baptiste Kempf jb at videolan.org
Sun Jan 4 17:54:00 CET 2009


On Sun, Jan 04, 2009 at 05:31:26PM +0100, git version control wrote :
> vlc | branch: master | Antoine Cellerier <dionoea at videolan.org> | Sun Jan  4 17:31:20 2009 +0100| [9f7c2895dc8f4251709259044e7f467ddb96b788] | committer: Antoine Cellerier 
> -    filter = new QRegExp( psz_tmp, Qt::CaseInsensitive );
> +    if( psz_tmp && *psz_tmp )
> +        filter = new QRegExp( psz_tmp, Qt::CaseInsensitive );
> +    else
> +        filter = NULL;

I don't understand the need of this.

Creating an empty QRegExp is fine and avoids supplementary checking
everytime we will have to use filter.

-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/



More information about the vlc-devel mailing list