[vlc-devel] commit: Remove bogus vlc_object_wait (no condition to wait on) ( Rémi Denis-Courmont )

git version control git at videolan.org
Sat Jan 24 19:57:55 CET 2009


vlc | branch: master | Rémi Denis-Courmont <rdenis at simphalempin.com> | Sat Jan 24 20:24:20 2009 +0200| [49c1e2a7adf7c5995cd5ebb6ee07ded00d8a4307] | committer: Rémi Denis-Courmont 

Remove bogus vlc_object_wait (no condition to wait on)

N.B.: libvlc snapshots remain seriously broken.
Vout is not locked when shooting. Variables are not safely set.
Vout thread does not access request field safely.
Multiple requests are not safe either. I probably missed some other
issues.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=49c1e2a7adf7c5995cd5ebb6ee07ded00d8a4307
---

 src/control/mediacontrol_audio_video.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/control/mediacontrol_audio_video.c b/src/control/mediacontrol_audio_video.c
index f783f51..f2367de 100644
--- a/src/control/mediacontrol_audio_video.c
+++ b/src/control/mediacontrol_audio_video.c
@@ -92,7 +92,6 @@ mediacontrol_snapshot( mediacontrol_Instance *self,
 
     vlc_object_lock( p_cache );
     vout_Control( p_vout, VOUT_SNAPSHOT );
-    vlc_object_wait( p_cache );
     vlc_object_release( p_vout );
 
     p_snapshot = ( snapshot_t* ) p_cache->p_private;




More information about the vlc-devel mailing list