[vlc-devel] [PATCH] Enable aspectratio parameter in mozillaplugin

Rémi Denis-Courmont remi at remlab.net
Fri Jun 12 09:02:23 CEST 2009


On Fri, 12 Jun 2009 00:01:08 +0200, Vicente Jiménez <googuy at gmail.com>
wrote:
> 1. Using vlc.video.aspectRatio from javascript works BUT this setting
> ends with the current playing media. It deactivates as soon as the
> next item (in the playlist or in loop) starts. Also setting it is not
> so easy, you need to wait for vlc.input.hasVout.

This is a generic problem with libvlc vout handling (and aout also).

IMHO, instead of looking for any single vout, it should:
 - Apply the setting to all existing vouts for the input,
 - Store the setting in the appropriate input variable for later vouts,
 - Not return an exception when there are no vouts.

This would ensure that the API works regardless of the number of outputs
and make it a less racy and easier to use.
I've been meaning to do this in 1.1, but I haven't had time this far. Help
welcome.

-- 
Rémi Denis-Courmont




More information about the vlc-devel mailing list