[vlc-devel] [PATCH] Fix hotkey problem. To be discussed

[Rémi Denis-Courmont]

Le mercredi 17 juin 2009 17:37:11 Cyril MATHE, vous avez écrit :
> Hi,
>
> There is currently no hotkey working in moz-plugin. This is because in
> hotkey.c vlc is unable to get the current p_input which is created by
> the play function (libvlc_media_player_play in moz-plugin case). So this
> solution add p_input to p_libvlc_int (because this struct is common in
> p_mi and p_intf) and we can get it in hotkey by p_intf->p_libvlc. So the
> aim is to find a better solution than that.

Using vlc_object_find() would be little LESS ugly... at least it wouldn't 
clutter the plugin ABI with this hack, and it wouldn't crash (I guess) if 
there are more than one input.

Anyway, the real problem is that hotkeys should be per-input but they are not. 
I have been meaning to fix this in 1.1, but I'm waiting for Laurent to push 
his vout changes first...

-- 
Rémi Denis-Courmont
http://www.remlab.net/