[vlc-devel] [PATCH] Add marq filter to libvlc

[Cyril MATHE]

Hello,

> I am sorry for being to clear enough here... I don't think having two
> arguments for the setter is a good idea. I'd like the idea that the
> getter is straight forward to implement.
> 
> Moreover a const char* should be used here.
> 
> To be more specific:
> libvlc_marq_set_option_as_int(libvlc_marq_int_option_t, int val);
> libvlc_marq_set_option_as_string(libvlc_marq_string_option_t, const
> char * string);
> 
> char * libvlc_marq_get_option_as_string(libvlc_marq_string_option_t);
> int libvlc_marq_get_option_as_int(libvlc_marq_int_option_t);
> 
> Should be the way to go in my opinion.
> 
> Pierre.

It's partly my fault, I was not sure, I sould ask before. I was thinking
that there was too much code lines repeat. Now it's exactly like you
want it to be. The patch is joined to this email.

Best Regards,
	Cyril