[vlc-devel] [PATCH] Win32: wrappers to work around %z printf limitations

[Rémi Denis-Courmont]

Le lundi 9 mars 2009 13:17:32 Pierre Ynard, vous avez écrit :
> +static inline int vlc_vprintf (const char *format, va_list ap)
> +{
> +    char *fmt = vlc_fix_format_string (format);
> +    int ret = vprintf (fmt ? fmt : format, ap);
> +    free (fmt);
> +    return ret;
> +}

Why not just return vlc_vfprintf(stdout, format, ap); ?

> +# ifdef HAVE_VASPRINTF
> +#  undef HAVE_VASPRINTF
> +# endif
> +# ifdef HAVE_ASPRINTF
> +#  undef HAVE_ASPRINTF
> +# endif

Not an issue, but the ifdefs are not needed.

Looks OK anyway.

-- 
Rémi Denis-Courmont
http://git.remlab.net/cgi-bin/gitweb.cgi?p=vlc-courmisch.git;a=summary