[vlc-devel] commit: Use the cpp to auto-update libvlc_event_type_name()'s dictionary. ( JP Dinger )

[Pierre d'Herbemont]

On Sep 1, 2009, at 6:00 PM, git version control wrote:

> vlc | branch: master | JP Dinger <jpd at videolan.org> | Mon Aug  3  
> 13:50:15 2009 +0200| [96a96f60bb0d1f2506e68b356897ceca6f6b586d] |  
> committer: JP Dinger
>
> Use the cpp to auto-update libvlc_event_type_name()'s dictionary.
>
> This breaks the new python bindings' trawling of the source.
>
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=96a96f60bb0d1f2506e68b356897ceca6f6b586d
> ---
>
> include/vlc/libvlc_events.h |  131 ++++++++++++++++++++++ 
> +--------------------
> src/control/event.c         |   60 ++++----------------
> 2 files changed, 82 insertions(+), 109 deletions(-)
>
> diff --git a/include/vlc/libvlc_events.h b/include/vlc/libvlc_events.h
> index 649fffa..021ad9a 100644
> --- a/include/vlc/libvlc_events.h
> +++ b/include/vlc/libvlc_events.h
> @@ -17,9 +17,9 @@
>  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>  * GNU General Public License for more details.
>  *
> - * You should have received a copy of the GNU General Public License
> - * along with this program; if not, write to the Free Software
> - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston MA  
> 02110-1301, USA.
> + * You should have received a copy of the GNU General Public  
> License along
> + * with this program; if not, write to the Free Software  
> Foundation, Inc.,
> + * 51 Franklin Street, Fifth Floor, Boston MA 02110-1301, USA.
>   
> *****************************************************************************/
>
> #ifndef LIBVLC_EVENTS_H
> @@ -44,70 +44,81 @@ extern "C" {
>  * @{
>  */
>
> +    /* Append new event types at the end. Do not remove, insert or
> +     * re-order any entry. The cpp will prepend libvlc_ to the  
> symbols. */
> +#define DEFINE_LIBVLC_EVENT_TYPES

This is the kind of hack I would avoid in public headers.

Pierre.