[vlc-devel] commit: normvol: do not handle impossible error ( Rémi Denis-Courmont )

git version control git at videolan.org
Sun Sep 27 12:08:41 CEST 2009


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sun Sep 27 12:47:43 2009 +0300| [82b9112d3e7af5b9905198040aaf7b5789b66d0b] | committer: Rémi Denis-Courmont 

normvol: do not handle impossible error

Open fails if p_sys is NULL.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=82b9112d3e7af5b9905198040aaf7b5789b66d0b
---

 modules/audio_filter/normvol.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/modules/audio_filter/normvol.c b/modules/audio_filter/normvol.c
index f10df66..f67f24c 100644
--- a/modules/audio_filter/normvol.c
+++ b/modules/audio_filter/normvol.c
@@ -253,9 +253,6 @@ static void Close( vlc_object_t *p_this )
     aout_filter_t *p_filter = (aout_filter_t*)p_this;
     aout_filter_sys_t *p_sys = p_filter->p_sys;
 
-    if( p_sys )
-    {
-        free( p_sys->p_last );
-        free( p_sys );
-    }
+    free( p_sys->p_last );
+    free( p_sys );
 }




More information about the vlc-devel mailing list