[vlc-devel] [vlc-commits] commit: live555: rtsp-caching is needed also for SDP ( Rémi Denis-Courmont )

[David Glaude]

This change was introduced because we noticed that when the SDP is not
aquired from an RTSP Describe, the --rtsp-caching parameter is not taken
into account.

We tested with
http://nightlies.videolan.org/build/win32/trunk-20100422-0003/<https://webmail.europarl.europa.eu/exchweb/bin/redir.asp?URL=http://nightlies.videolan.org/build/win32/trunk-20100422-0003/>(because
the 1.1.0-preX branch was not available) but it is still not
working.
"C:/Program Files/VideoLAN/VLC/VLC.exe" -vvv --rtsp-caching=1000 --verbose=2
MCAST2.sdp &> logs1000.txt
[01f6d3e8] main input debug: Stream buffering done (319 ms in 301 ms)

"C:/Program Files/VideoLAN/VLC/VLC.exe" -vvv --rtsp-caching=5000 --verbose=2
MCAST2.sdp &> logs5000.txt
[00e3b460] main input debug: Stream buffering done (320 ms in 259 ms)

However, even with an old 1.1.0-pre2 I was getting very nice (low latency)
result with a
"C:/Program Files/VideoLAN/VLC/VLC.exe" -vvv --rtsp-caching=100--clock-jitter=0
--verbose=2 rtsp://1.2.3.4/Test

How can we help you find the right place to initialise rtsp-caching whatever
if the SDP file is read from a local file or if it is http downloaded (our
targeted use case)?

David Glaude

2010/4/21 <git at videolan.org>

> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Wed Apr 21
> 23:33:51 2010 +0300| [9ae385f64cedf3d88615e6a0ec6a10a3e3d68f49] | committer:
> Rémi Denis-Courmont
>
> live555: rtsp-caching is needed also for SDP
>
> >
> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=9ae385f64cedf3d88615e6a0ec6a10a3e3d68f49
> ---
>
>  modules/demux/live555.cpp |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/modules/demux/live555.cpp b/modules/demux/live555.cpp
> index b4188c3..2f0f4e2 100644
> --- a/modules/demux/live555.cpp
> +++ b/modules/demux/live555.cpp
> @@ -274,10 +274,7 @@ static int  Open ( vlc_object_t *p_this )
>             return VLC_EGENERIC;
>         }
>     }
> -    else
> -    {
> -        var_Create( p_demux, "rtsp-caching",
> VLC_VAR_INTEGER|VLC_VAR_DOINHERIT );
> -    }
> +    var_Create( p_demux, "rtsp-caching", VLC_VAR_INTEGER|VLC_VAR_DOINHERIT
> );
>
>     p_demux->pf_demux  = Demux;
>     p_demux->pf_control= Control;
>
> _______________________________________________
> vlc-commits mailing list
> vlc-commits at videolan.org
> http://mailman.videolan.org/listinfo/vlc-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20100422/faabd064/attachment.html>