[vlc-devel] Patch for C64 SID suppport

[Christophe Mutricy]

Hello,

Tiny comments


On Thu, Dec 02, 10 at 15:57 -0600, Alan Fischer wrote:
> +  AC_ARG_ENABLE(sid,
> +    [  --enable-sid            C64 SID support (default auto)])
> +  AS_IF([test "${enable_sid}" != "no"], [
> +    AC_CHECK_HEADER([sidplay/sidplay2.h], [
> +      AC_DEFINE(SIDPLAY_VERSION,2,[Sidplay version, 1 or 2])
> +      VLC_ADD_LIBS([sid], [-lsidplay2 -lresid-builder])
> +      VLC_ADD_PLUGIN([sid])
> +    ], [
> +      AC_CHECK_HEADER([sidplay/player.h], [
> +        AC_DEFINE(SIDPLAY_VERSION,1,[Sidplay version, 1 or 2])
> +        VLC_ADD_LIBS([sid], [-lsidplay])
> +        VLC_ADD_PLUGIN([sid])
>  PKG_ENABLE_MODULES_VLC([OGG], [], [ogg >= 1.0], [Ogg demux support], [auto])

You should use pkg-config if libsidplay provides .pc (and they are not
buggy)

> + * Copyright © 2010 Rémi Denis-Courmont

Somehow i doubt there is many homonym to courmish

> + *
> +
> +#include <stdarg.h>
> +#include <limits.h>

Already included by vlc_common.h iirc



-- 
Xtophe