[vlc-devel] [PATCH] Qt/ML: New Models for Playlist UI

Srikanth Raju srikiraju at gmail.com
Wed Dec 29 15:23:44 CET 2010


Hi,

On Tue, Dec 28, 2010 at 5:20 AM, Jean-Baptiste Kempf <jb at videolan.org> wrote:
> As much as I don't like the one-big-patch way especially because a
> first patch to move the PLModel to VLCModel+PLModel was necessary, I
> won't nitpick too much now.
>

Broken down patches further

>  - strdup( qtu(data.toString()) ) is dubious, in setData
>
Could you explain this? I didn't see anything wrong with it


-- 
Regards,
Srikanth Raju
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Qt-ML-VLC-Model.patch
Type: text/x-patch
Size: 5688 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20101229/d4185e2a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Qt-ML-ML-Model-and-Item.patch
Type: text/x-patch
Size: 42978 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20101229/d4185e2a/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Qt-ML-Extend-Playlist-model-from-VLCModel.patch
Type: text/x-patch
Size: 6737 bytes
Desc: not available
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20101229/d4185e2a/attachment-0002.bin>


More information about the vlc-devel mailing list