[vlc-devel] [PATCH] Avoid a crash with some corrupted mkvs

Jean-Baptiste Kempf jb at videolan.org
Fri Dec 23 21:14:58 CET 2011


On Fri, Dec 23, 2011 at 09:12:59PM +0100, Denis Charmet wrote :
> Le vendredi 23 décembre 2011 à 09:09:31, Jean-Baptiste Kempf a écrit :
> > On Fri, Dec 23, 2011 at 09:02:06PM +0100, Denis Charmet wrote :
> > > Le vendredi 23 décembre 2011 à 08:45:08, Rémi Denis-Courmont a écrit :
> > > >    Hello,
> > > > 
> > > > On Friday 23 December 2011, Denis Charmet wrote:
> > > > This is not very kosher if i_extra_data < sizeof(BITMAPINFOHEADER).
> > > 
> > > I totally agree but well... a bug was filed... 
> > > 
> > 
> > What I understood from Rémi's mail is that you should test i_extra_data
> > < sizeof(BITMAPINFOHEADER) before doing the substraction.
> > 
> Oh... my bad I didn't understand as the test is done before the patch
> (line 917)

Maybe, also, I understood WORONG.


-- 
Jean-Baptiste Kempf
http://www.jbkempf.com/ - +33 672 704 734
Sent from my Electronic Device



More information about the vlc-devel mailing list