[vlc-devel] [PATCH] MacOS: always specify a minimum-sdk

[Rafaël Carré]

Le Wed, 30 Nov 2011 16:04:40 +0100,
Jean-Baptiste Kempf <jb at videolan.org> a écrit :

> This fixes issues on X.6 and X.7 when compiled with SDK10.5
> The configure would fail to see -crt10.6 library and die on poll()

If you build with sdk10.5, it should not link with -crt10.6, right?

> ---
>  configure.ac |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index f051ecd..3948076 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -168,6 +168,9 @@ case "${host_os}" in
>      AC_ARG_WITH(macosx-version-min,
>        [AS_HELP_STRING([--with-macosx-version-min=VERSION],
>          [compile for MacOS X VERSION and above])])
> +    if test "${with_macosx_version_min}" = "" ; then
> +       with_macosx_version_min=10.5
> +    fi 

>      if test "${with_macosx_version_min}" != "" ; then

you can remove that test because it's never empty with your patch

>          CPP="${CPP} -mmacosx-version-min=${with_macosx_version_min}"
>          CC="${CC} -mmacosx-version-min=${with_macosx_version_min}"



-- 
Rafaël Carré