[vlc-devel] [PATCH] Added option to disable chapter generation from marks file.

[Janne Kujanpää]

On 22.9.2011 19:12, Jean-Baptiste Kempf wrote:
> On Thu, Sep 22, 2011 at 02:52:05AM +0300, Janne Kujanpää wrote :
>> +    int64_t i_last_frame = -10000;
>
> Why not -1 ?
It's not enough. If there is cutmark just beginning of file it will 
cause chapters not to be created. Added macro to use as initial value 
and inside if clause.

>
>> +        if ( i_frame - i_last_frame<  45 )
> Trailing space.
>
>> +        i_last_frame=i_frame;
> Missing spaces around "="
>
Time to read code conventions again and recheck twice before send.
Fixed version as an attachment.

Happy coding,

-- 
Janne Kujanpää
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Added-option-to-disable-chapter-generation-from-mark.patch
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20110922/140b672b/attachment.ksh>