[vlc-devel] [PATCH 2/3] OS/2: Include ctype.h in modules/demux/playlist/playlist.c

[Rémi Denis-Courmont]

   Hello,

On Saturday 25 August 2012, Måns Rullgård wrote:
> "Rémi Denis-Courmont" <remi at remlab.net> writes:
> > Le vendredi 24 août 2012 17:17:25 Måns Rullgård, vous avez écrit :
> >> ctype.h is a standard header so keep things simple and include it
> >> unconditionally.
> > 
> > The code that needs <ctype.h> in this file is _not_ standard. It is
> > Windows- specific.
> 
> Apparently OS/2 needs it too.
> 
> > I don't see the need to include the headers on all platforms.
> 
> What harm does it do?

I don't think there is harm either way. I just like to not include unneeded 
headers.

However, isalpha() on POSIX depends on the locale. And that would be incorrect 
in this context: the affected code wants to check for ASCII letters only. 
Perhaps <ctype.h> should be removed altogether there.

-- 
Rémi Denis-Courmont
http://www.remlab.info