[vlc-devel] [PATCH] aout intf: implement functions to change volume and also show the appropriate osd text

Rémi Denis-Courmont remi at remlab.net
Wed Feb 1 16:01:10 CET 2012


On Wed, 1 Feb 2012 15:59:34 +0100, "Felix Paul Kühne"
<fkuehne.videolan at googlemail.com> wrote:
> Hello,
> 
> On 01.02.2012, at 15:52, David Fuhrmann wrote:
> 
>>> OSD stuff does not belong in aout.
>> 
>> I repeatedly asked where would be the best place to implement this
>> functionality. Up to now I got no useful answer. For me the current
place
>> seems to be the most sensible one.
>> It would be good to get a clear proposition from one of you about this.
>> ;-)
> 
> IMO, the OSD code should be called directly from the interface within
the
> respective methods. A good place would be the CoreInteraction class and
its
> audio related called.
> 
> Any other opinion, guys?

I don't see why an interface should use OSD, but yes.

-- 
Rémi Denis-Courmont
http://www.remlab.net/



More information about the vlc-devel mailing list