[vlc-devel] [PATCH 1/3] macosx: reenable audio items on osd

[Rémi Denis-Courmont]

   Hello,

Please don't use action IDs (except for real hotkeys). We have better 
functions for this.

On Friday 20 January 2012, David Fuhrmann wrote:
> This reverts commit 0f3ee76af70c5e27ca9fe67238a59a3cc594cf93.
> 
> As suggested in trac. fixes #5837
> ---
>  modules/gui/macosx/CoreInteraction.m |    9 +++------
>  1 files changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/modules/gui/macosx/CoreInteraction.m
> b/modules/gui/macosx/CoreInteraction.m index 2044c42..7722752 100644
> --- a/modules/gui/macosx/CoreInteraction.m
> +++ b/modules/gui/macosx/CoreInteraction.m
> @@ -409,20 +409,17 @@ static VLCCoreInteraction *_o_sharedInstance = nil;
> 
>  - (void)volumeUp
>  {
> -    playlist_t * p_playlist = pl_Get( VLCIntf );
> -    aout_VolumeUp( p_playlist, 1, NULL );
> +    var_SetInteger( VLCIntf->p_libvlc, "key-action", ACTIONID_VOL_UP );
>  }
> 
>  - (void)volumeDown
>  {
> -    playlist_t * p_playlist = pl_Get( VLCIntf );
> -    aout_VolumeDown( p_playlist, 1, NULL );
> +    var_SetInteger( VLCIntf->p_libvlc, "key-action", ACTIONID_VOL_DOWN );
>  }
> 
>  - (void)mute
>  {
> -    playlist_t * p_playlist = pl_Get( VLCIntf );
> -    aout_ToggleMute( p_playlist, NULL );
> +    var_SetInteger( VLCIntf->p_libvlc, "key-action", ACTIONID_VOL_MUTE );
>  }
> 
>  - (BOOL)isMuted
-- 
Rémi Denis-Courmont
http://www.remlab.info