[vlc-devel] [vlc-commits] macosx: replace all 'key-action' calls with their proper counter-parts

[Felix Paul Kühne]

Hello David,

On 10.02.2013, at 00:41, David Fuhrmann <david.fuhrmann at gmail.com> wrote:

> I put these key-actions on purpose here, because of some criticism before. Apple remote should be treated as hotkey actions, so that the OSD display is shown, with the the volume change is visible from the sofa.
Agreed. I'll push a partial revert for this, while I think that this should be handled by the core instead, so the vout feedback is triggered regardless of core events or hotkeys leading to the requested action.

> Furthermore, this commit breaks play & pause button / space bar, and the scrolling direction for seeking is wrong now.
Interesting, since the scrolling direction should not be affected by this commit. I'll investigate.
I'll also retest the play/pause behavior, since in fact, nothing should have been changed. If visual feedback is missing, the same thing is applicable as above, hence it should be handled by the core IMO, since it isn't clean that the UI triggers a control module to interact with the core..

Best regards,

Felix